Add support for skymap with planned wobble pointings #29
Conversation
HealthyPear
added
enhancement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HealthyPear
force-pushed
the
wobble_skymap
branch
2 times, most recently
from
16faa63 to
1390182
Compare
HealthyPear
force-pushed
the
wobble_skymap
branch
from
1390182 to
1418fc1
Compare
HealthyPear
force-pushed
the
wobble_skymap
branch
from
1418fc1 to
a81ae89
Compare
|
One thing that is missing here is the possibility to add an extended source, but I would prefer to do it after #33 so we have the gammapy config file with the sky models |
|
One thing I need to fix is the position angle of the wobbles: I just realized that I am using astropy's convention (0 deg is North and then increase counterclockwise) rather than the IACT convention (0 deg is West and then increase clockwise) easy fix
|
Fix nested quotes plots.wobble_skymap
HealthyPear
force-pushed
the
wobble_skymap
branch
from
a81ae89 to
4521302
Compare
We were using astropy's convention (0 deg is North and then increase counterclockwise) rather than the IACT convention (0 deg is West and then increase clockwise)
|
OK wobble position angle is now fixed |
|
I need to bump the minimum version of python to 3.10 as now starplot requires it due to some upstream dependencies. Anyway Python 3.9 is about to die soon (see https://devguide.python.org/versions/) |
A-posteriori, - updated wobble skymap function for new version of starplot - moved plot_observability_constraints_grid and create_observability_heatmap to plots.observability - removed save testing figure in docs
1 participant
Closes #11.
Here is an example:
Not super configurable, but a first version.