Set info logging level in find_tailcuts

[moralejo]

Not sure if there is a better way to set it (let me know if that is the case). Doing it in the script which calls the function did not work.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.86%. Comparing base (76540cc) to head (604988c).

Files with missing lines	Patch %	Lines
lstchain/image/cleaning.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   72.86%   72.86%   -0.01%     
==========================================
  Files         137      137              
  Lines       14515    14516       +1     
==========================================
  Hits        10577    10577              
- Misses       3938     3939       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[morcuended]

@morcuended Are the loggers of the script and of the called functions independent? Should I pass the logging level explicitly as an argument of find_tailcuts? I want it always set to "info", so the original code should do.

In principle not, I think it should be controlled by the level set in the main script calling the other module (see example at the top of https://docs.python.org/3/library/logging.html). Maybe need to set explicitly the level for file handler as well.

In lstchain_find_tailcuts.py

def main():
    args = parser.parse_args()

    output_dir = args.output_dir.absolute()
    output_dir.mkdir(exist_ok=True, parents=True)

    log.setLevel(logging.INFO)
    
    # Console handler
    console_handler = logging.StreamHandler(sys.stdout)
    console_handler.setLevel(logging.INFO)
    logging.getLogger().addHandler(console_handler)

    # File handler
    log_file = args.log_file or f'log_find_tailcuts_Run{run_id:05d}.log'
    log_file = output_dir / log_file
    file_handler = logging.FileHandler(log_file, mode='w')
    file_handler.setLevel(logging.INFO)
    logging.getLogger().addHandler(file_handler)
    ...

[moralejo]

I will try, thanks a lot for the info!

[moralejo]

Adding the console handler resulted in duplication of the (incomplete) output in stdout.
Then adding the setting for the file handler did not help either. Will keep trying.

[moralejo]

@morcuended I tried to follow the suggestions in the link you sent and did not help. The only way I seem to be able to activate INFO logging is inside cleaning.py

[morcuended]

I do not know the reason why. It is still strange to me that it is not controlled by the main script calling the function.

Therefore, use the definition inside the function for the time being.