Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailcut finder function and script #1325
Tailcut finder function and script #1325
Changes from 19 commits
9f698dd
7a707e3
afd9ba6
47115f0
2336cdb
be28773
1c8aa49
fcaad2f
c359bf6
0733892
ee6f29f
fb1ca4d
ef812ce
17a15c5
2a677b4
16bffee
c115c11
9269f2c
3fd7b3a
cf54e81
794f992
353fb18
b78758c
9d88a86
ac61081
c8c47de
2913357
7486271
c02bf8e
45a0cfa
8f80135
3f0749e
9f344d4
66add8b
57725a7
684d2ea
9425c83
9259b25
69cef5c
0b0eebb
ea23283
fbc5cd1
24aa61f
9f5df1d
563bc26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 85 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log level should be defined in the main script not inside this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it is enough to remove that line, right? - if so, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it was not... :-(
I just realized now that important info on unreliable pixels & outliers is now missing from the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morcuended Are the loggers of the script and of the called functions independent? Should I pass the logging level explicitly as an argument of find_tailcuts? I want it always set to "info", so the original code should do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's continue in #1349
Check warning on line 88 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L88
Check warning on line 92 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L91-L92
Check warning on line 96 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L96
Check warning on line 100 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L100
Check warning on line 103 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L103
Check warning on line 108 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L106-L108
Check warning on line 111 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L110-L111
Check warning on line 115 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L113-L115
Check warning on line 119 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L117-L119
Check warning on line 124 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L123-L124
Check warning on line 127 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L126-L127
Check warning on line 130 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L129-L130
Check warning on line 133 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L132-L133
Check warning on line 137 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L137
Check warning on line 141 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L139-L141
Check warning on line 144 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L144
Check warning on line 146 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L146
Check warning on line 151 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L151
Check warning on line 156 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L155-L156
Check warning on line 162 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L161-L162
Check warning on line 165 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L164-L165
Check warning on line 169 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L168-L169
Check warning on line 173 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L172-L173
Check warning on line 177 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L177
Check warning on line 180 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L179-L180
Check warning on line 184 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L184
Check warning on line 187 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L186-L187
Check warning on line 189 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L189
Check warning on line 191 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L191
Check warning on line 209 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L208-L209
Check warning on line 213 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L211-L213
Check warning on line 233 in lstchain/image/cleaning.py
lstchain/image/cleaning.py#L232-L233
Check warning on line 49 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L48-L49
Check warning on line 54 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L51-L54
Check warning on line 58 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L56-L58
Check warning on line 61 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L60-L61
Check warning on line 65 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L64-L65
Check warning on line 73 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L68-L73
Check warning on line 76 in lstchain/scripts/lstchain_find_tailcuts.py
lstchain/scripts/lstchain_find_tailcuts.py#L76