Skip to content

fix: repair syntax errors that break the build on main - #1683

Merged
csxark merged 1 commit into
csxark:mainfrom
vedant7007:build/fix-build
Aug 29, 2026
Merged

fix: repair syntax errors that break the build on main#1683
csxark merged 1 commit into
csxark:mainfrom
vedant7007:build/fix-build

Conversation

@vedant7007

@vedant7007 vedant7007 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What & why

Closes #1682.

main doesn't parse right now — two committed syntax errors break the build before typecheck/tests run.

Changes

package.json — the overrides block was invalid JSON: missing a comma after nanoid and a duplicate postcss key. Deduped postcss to the newer pin (^8.5.26) and restored the comma. npm ci now parses it.

lib/workers/cryptoWorkerClient.ts:71 — two statements were jammed onto one line after the Worker constructor (a TS parse error). Split the onmessage assignment onto its own line.

Both are mechanical, no behavior change.

Verification

  • node -e "JSON.parse(require('fs').readFileSync('package.json'))" — parses.
  • tsc --noEmit no longer reports the cryptoWorkerClient.ts:71 parse error (remaining tsc output is unrelated pre-existing items in lib/cipher/*, untouched here).

Contributing as part of Elite Coders Summer of Code (ECSoC 2026).

Summary by CodeRabbit

  • Chores
    • Updated the bundled PostCSS version for improved maintenance and compatibility.
  • Style
    • Improved code formatting without changing application behavior.

package.json: the overrides block was missing a comma after nanoid and
had a duplicate postcss key, making it invalid JSON (npm ci fails to
parse it). Deduped postcss to the newer pin and fixed the comma.

cryptoWorkerClient.ts: two statements were on one line with no separator
after the Worker constructor, a TypeScript parse error. Split onto
separate lines.
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@vedant7007 is attempting to deploy a commit to the csxark's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Thank You for Your Contribution

Hello @vedant7007,

Thank you for submitting a Pull Request to CryptoViz. We appreciate the time and effort you've invested in contributing to the project.

Your Pull Request has been received successfully and will be reviewed by the maintainers as soon as possible.

📋 Pull Request Checklist

  • ✅ Linked the related issue
  • ✅ No merge conflicts
  • ✅ Synced with the latest main branch
  • ✅ Build passes successfully
  • ✅ All tests pass

Ensuring these requirements are met helps streamline the review process and enables maintainers to review your contribution more efficiently.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

  • ⭐ Starring the repository
  • 🍴 Forking the repository
  • 👤 Following Ark on GitHub
  • 💼 Connecting on LinkedIn
  • 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!

Thank you once again for contributing to CryptoViz. We appreciate your support and look forward to reviewing your contribution.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b4273cc6-675c-49e9-ba2f-5a1f10912945

📥 Commits

Reviewing files that changed from the base of the PR and between 264d746 and d65abf7.

📒 Files selected for processing (2)
  • lib/workers/cryptoWorkerClient.ts
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change fixes invalid JSON in package.json and a TypeScript parse error in cryptoWorkerClient.ts. It updates the postcss override and separates two Worker statements. Runtime behavior remains unchanged.

Changes

Build Parse Fixes

Layer / File(s) Summary
Syntax corrections
package.json, lib/workers/cryptoWorkerClient.ts
The postcss override now uses ^8.5.26 with valid JSON syntax. The Worker initialization and message-handler assignment now use separate statements.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d65ab

The changes restore package and TypeScript parsing without altering runtime behavior or public interfaces. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: csxark, jidnyasa-p

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: repairing syntax errors that prevent the main branch from building.
Linked Issues check ✅ Passed The changes satisfy issue #1682. They repair the invalid package.json overrides block, preserve postcss at ^8.5.26, remove the duplicate key, restore the comma, and separate the Worker statements with…
Out of Scope Changes check ✅ Passed All changes are directly related to issue #1682. The package.json reorder and TypeScript line split support the two required syntax repairs, with no unrelated behavioral changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Linked Issues check

Explanation

The changes satisfy issue #1682. They repair the invalid package.json overrides block, preserve postcss at ^8.5.26, remove the duplicate key, restore the comma, and separate the Worker statements without changing behavior.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@csxark csxark added ECSoC26 Elite Coders Summer of Code 2026 good-issue and removed needs review labels Aug 28, 2026
@csxark
csxark merged commit 3af54bd into csxark:main Aug 29, 2026
4 of 10 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Pull Request Merged

Hello @vedant7007,

Thank you for your contribution to CryptoViz. Your Pull Request has been reviewed and successfully merged into the project.

We sincerely appreciate the time and effort you invested in improving the project. Contributions like yours help make CryptoViz better for the entire community.

We look forward to your future contributions and hope to collaborate with you again.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

  • ⭐ Starring the repository
  • 🍴 Forking the repository
  • 👤 Following Ark on GitHub
  • 💼 Connecting on LinkedIn
  • 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26-L1 ECSoC26 Elite Coders Summer of Code 2026 good-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main does not build: invalid package.json + parse error in cryptoWorkerClient.ts

2 participants