Skip to content

Email Case Sensitivity #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions csm_web/scheduler/migrations/0033_alter_user_email.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Generated by Django 3.2.15 on 2023-02-03 01:55

from django.db import migrations
import scheduler.models


class Migration(migrations.Migration):

dependencies = [
('scheduler', '0032_word_of_the_day'),
]

operations = [
migrations.AlterField(
model_name='user',
name='email',
field=scheduler.models.LowercaseEmailField(max_length=254, unique=True),
),
]
13 changes: 13 additions & 0 deletions csm_web/scheduler/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,21 @@ def week_bounds(date):
return week_start, week_end


class LowercaseEmailField(models.EmailField):
"""
Override EmailField to convert emails to lowercase before saving.
"""

def to_python(self, value):
value = super(LowercaseEmailField, self).to_python(value)
if isinstance(value, str):
return value.lower()
return value


class User(AbstractUser):
priority_enrollment = models.DateTimeField(null=True, blank=True)
email = LowercaseEmailField(unique=True)

def can_enroll_in_course(self, course, bypass_enrollment_time=False):
# check restricted first
Expand Down
20 changes: 20 additions & 0 deletions csm_web/scheduler/tests/models/test_user.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pytest

from django.db.utils import IntegrityError
from scheduler.models import User


Expand All @@ -13,3 +14,22 @@ def test_create_user():
assert user.username == username
assert User.objects.count() == 1
assert User.objects.get(email=email).username == username


@pytest.mark.django_db
def test_same_email():
email = "[email protected]"
username = "test"
caps_email = "[email protected]"
caps_username = "TEST"
user, created = User.objects.get_or_create(email=email, username=username)
with pytest.raises(IntegrityError):
caps_user, caps_created = User.objects.get_or_create(email=caps_email, username=caps_username)

assert created
assert user.email == email
assert user.email != caps_email
assert user.username == username
assert user.username != caps_username
assert User.objects.count() == 1
assert User.objects.get(email=email).username == username