Correctly fallback to relogin when token renew fails #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every type of request error should trigger a token renew and then a login re-attempt.
wrouesnel
changed the title
Test cases used to check for an exact match of extra keys. Make the test more robust by only checking for a near match.
for more information, see https://pre-commit.ci
The device data return has changed to returning flat values rather
then `{ "key" : {"value": value }}` format.
for more information, see https://pre-commit.ci
Author
|
This PR now contains fixes for the latest breaking change for the uHoo cloud API. |
wrouesnel
force-pushed
the
master
branch
4 times, most recently
from
41e8c83 to
ed868c7
Compare
This is a breaking API change introduced by uHoo upstream and has been adapted.
wrouesnel
force-pushed
the
master
branch
3 times, most recently
from
eef8d21 to
b8a03a4
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every type of request error should trigger a token renew and then a login re-attempt.
This PR fixes the problem by making the two types of request errors proper subclasses of RequestError, which in turn is a subclass of UhooError.
I've tested this working successfully to fix the uhoo-homeassistant plugin by simply updating the manifest file to pull this version from git instead (version is bumped to 0.0.6a2 to distinguish).