Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary client for Set / UnsetAttr #5123

Merged
merged 3 commits into from
Mar 13, 2025
Merged

Conversation

jessegeens
Copy link
Contributor

@jessegeens jessegeens commented Mar 13, 2025

EOS < 5.3 has a couple of bugs related to attributes:

  • Attributes can only be removed as root or the owner, but over gRPC we cannot become root
  • The recursive property is ignored on set attributes over gRPC

We circumvent these two issues by calling the binary client until we have deployed EOS 5.3\

That means that this PR has to be reverted once EOS 5.3 is live

Copy link

update-docs bot commented Mar 13, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@glpatcern
Copy link
Member

This is ugly, as discussed, but we need it. At this point I'd add the same for the SetAttr, so that we fix the other issue with recursivity, and once we deploy EOS 5.3 this whole PR can be reverted.

@jessegeens jessegeens changed the title Use binary client + root for UnsetAttr Use binary client for Set / UnsetAttr Mar 13, 2025
@jessegeens jessegeens merged commit 29a7113 into master Mar 13, 2025
15 checks passed
@diocas diocas deleted the fix/unset-attr-as-root branch March 13, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants