Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dirty] Fix Password Protected Folders #5099

Closed
wants to merge 1 commit into from

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Feb 25, 2025

Just to be crystal clear: I don't like the fix very much. But it could help avoiding the password policies on Password Protected Folders.

@2403905 what do you think? How much do you NOT like it?

Copy link

update-docs bot commented Feb 25, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905
Copy link

2403905 commented Feb 25, 2025

@kobergj We could use It but:

  1. Should we check if the ".PasswordProtectedFolders" is in a Personal space root to avoid some manipulation going around the password policies for the regular public links like <roo>/<subfolder>/.PasswordProtectedFolders/?
  2. If user able to update the password we should fix the UpdatePublicShare to
    if updatePassword && len(setPassword) > 0 {
  3. Is these changes relevant for the osc ?https://github.com/cs3org/reva/blob/edge/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go

@glpatcern glpatcern closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants