Skip to content

Fix URI#host= to wrap IPv6 address in brackets #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 28, 2025
Merged

Fix URI#host= to wrap IPv6 address in brackets #16164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7477dc5
fix URI when initialized with an IPv6 address
stakach Sep 23, 2025
a4188ec
add to normalize! function
stakach Sep 23, 2025
b82adb0
update normalize documentation
stakach Sep 23, 2025
bbe710b
add specs
stakach Sep 23, 2025
35ce6ee
improve specs
stakach Sep 23, 2025
0ecc0f0
replace host setter
stakach Sep 23, 2025
1cc595b
restore normalize comment
stakach Sep 23, 2025
6daea3b
restore initialize signature
stakach Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions spec/std/uri_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,42 @@ describe "URI" do
it { URI.new(path: "/foo").hostname.should be_nil }
end

describe "#host" do
it "works with IPv6 address literals" do
uri = URI.new("http", "[::1]", path: "foo")
uri.hostname.should eq("::1")
uri.host.should eq("[::1]")
uri.to_s.should eq "http://[::1]/foo"
uri.host = "[::1]"
uri.to_s.should eq "http://[::1]/foo"

uri = URI.new("http", "::1", path: "foo")
uri.hostname.should eq("::1")
uri.host.should eq("[::1]")
uri.to_s.should eq "http://[::1]/foo"
uri.host = "::1"
uri.to_s.should eq "http://[::1]/foo"
end

it "works with IPv4 addresses" do
uri = URI.new("http", "192.168.0.2", path: "foo")
uri.hostname.should eq("192.168.0.2")
uri.host.should eq("192.168.0.2")
uri.to_s.should eq "http://192.168.0.2/foo"
uri.host = "192.168.0.2"
uri.to_s.should eq "http://192.168.0.2/foo"
end

it "works with domain names" do
uri = URI.new("http", "test.domain", path: "foo")
uri.hostname.should eq("test.domain")
uri.host.should eq("test.domain")
uri.to_s.should eq "http://test.domain/foo"
uri.host = "test.domain"
uri.to_s.should eq "http://test.domain/foo"
end
end

describe "#authority" do
it { URI.new.authority.should be_nil }
it { URI.new(scheme: "scheme").authority.should be_nil }
Expand Down
8 changes: 6 additions & 2 deletions src/uri.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ class URI
getter host : String?

# Sets the host component of the URI.
setter host : String?
def host=(host : String?)
@host = host && !host.starts_with?('[') && host.includes?(':') ? "[#{host}]" : host
end

# Returns the port component of the URI.
#
Expand Down Expand Up @@ -175,7 +177,9 @@ class URI

def_equals_and_hash scheme, host, port, path, query, user, password, fragment

def initialize(@scheme = nil, @host = nil, @port = nil, @path = "", query : String | Params | Nil = nil, @user = nil, @password = nil, @fragment = nil)
def initialize(@scheme = nil, host = nil, @port = nil, @path = "", query : String | Params | Nil = nil, @user = nil, @password = nil, @fragment = nil)
# wrap IPv6 addresses
self.host = host
@query = query.try(&.to_s)
end

Expand Down