Skip to content

Improve HKDF API #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 2, 2025
Merged

Improve HKDF API #1177

merged 5 commits into from
Oct 2, 2025

Conversation

keks
Copy link
Member

@keks keks commented Sep 24, 2025 •
edited
Loading

Instead of creating a kdf crate, I am iterating on the HKDF API.

  • docs & examples
  • use secret types
  • move hkdf into crates/

@keks keks linked an issue Sep 24, 2025 that may be closed by this pull request
KDF trait #1037
Closed
2 tasks
franziskuskiefer
franziskuskiefer reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't want to put the APIs just into the respective crates? What APIs should consumers use when they only want to use blake2 or hkdf in this case?

@keks keks force-pushed the keks/hkdf-slice branch 2 times, most recently from 71a3837 to c69c994 Compare September 30, 2025 08:37
@keks keks changed the title First Take at KDF crate Improve HKDF API Sep 30, 2025
@keks
Copy link
Member Author

keks commented Sep 30, 2025

I dropped the attempts to standardise KDF and PRF and instead tried making the hkdf API a bit neater.

@keks keks marked this pull request as ready for review September 30, 2025 10:22
@keks keks requested review from a team as code owners September 30, 2025 10:22
@keks keks mentioned this pull request Sep 30, 2025
Open
24 tasks
jschneider-bensch
jschneider-bensch previously requested changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, beside the issue with the doc test.
Thanks for simplifying the PSQ code while you were updating it to the new API!

franziskuskiefer
franziskuskiefer approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few nits. But leaving an r+ already.

@keks keks force-pushed the keks/hkdf-slice branch from 680e32c to aec5f9c Compare October 1, 2025 10:30
@keks keks force-pushed the keks/hkdf-slice branch from aec5f9c to 25959ef Compare October 1, 2025 13:54
@keks keks requested a review from jschneider-bensch October 1, 2025 14:37
@github-actions github-actions bot dismissed jschneider-bensch’s stale review October 1, 2025 14:37

Review re-requested

jschneider-bensch
jschneider-bensch approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keks keks added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 7d9c047 Oct 2, 2025
117 of 121 checks passed
@keks keks deleted the keks/hkdf-slice branch October 2, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

Assignees

@keks keks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KDF trait

3 participants

@keks @franziskuskiefer @jschneider-bensch