Add full type check for SHA3 portable #1157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parrot7483
force-pushed
the
Parrot7483/sha3-type-check
branch
from
8f7a614 to
223bcaf
Compare
Parrot7483
commented
Sep 18, 2025
There was a problem hiding this comment.
It might be a good idea to switch back to a theta_rho function (how it was before lax check), splitting it up the same way.
Parrot7483
commented
Sep 18, 2025
| } | ||
|
|
||
| #[cfg(hax)] | ||
| pub(crate) fn keccak_xof_state_inv< |
There was a problem hiding this comment.
PARALLEL_LANES is not needed here anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full type checking for the SHA3 portable version for #395
Extract using
hax.py extract --portable, prove usinghax.py prove.Besides prove code the following things where changed:
libcrux-sha3/src/generic_keccak/xof.rsabsorb_fullfunction inlibcrux-sha3/src/generic_keccak/xof.rspreviously did not always consume the internal buffer when it was full. This state could only be reached by misusing the API. The only bug I found.This version contains a few things I would consider "hacks"
hax_lib::fstar::replaceimpl From<u32> for Algorithmdoes not work because of the panic.libcrux-sha3/src/generic_keccak/xof.rsthe#[hax_lib::fstar::options("...")]has no effect. I use anhax_lib::fstar::beforeinstead