-
Notifications
You must be signed in to change notification settings - Fork 43
feat(lean): Add support for namespaces #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clementblaudeau
wants to merge
17
commits into
main
Choose a base branch
from
clement/lean-namespaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
362f913
fix(lean): use fresh names for constraints on associated types
clementblaudeau 6d45859
feat(engine/lean): allow default methods for traits
clementblaudeau 437cf5b
feat(rengine/lean): print default methods for traits
clementblaudeau d92c197
test(lean): default methods
clementblaudeau db84f5b
test(lean): add missing core models tests in lean + update snapshot
clementblaudeau 6d91bca
chore: CHANGELOG
clementblaudeau 5c4ea61
chore: update snapshots
clementblaudeau 6cc7db4
refactor(rengine): introduce FreshModule case for GlobalId
clementblaudeau cdb7ca6
feat(rengine): add partial equality of PathSegment and GlobalId
clementblaudeau c4fd11f
refactor(rengine): move the apply function inside the Backend trait
clementblaudeau 467d36a
fix(rengine): return the closest module, not the first
clementblaudeau ff7d02e
feat(lean): improve output
clementblaudeau 9ce00e4
chore(lean): update snapshots
clementblaudeau 95f6364
fix(rengine): emit a proper error message for fresh modules
clementblaudeau ccaa2fc
chore: CHANGELOG
clementblaudeau 758f81c
Update rust-engine/src/ast/identifiers/global_id.rs
clementblaudeau 86d39d1
refactor(rengine): rename [into_owned_concrete_id]
clementblaudeau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,4 @@ pretty = "0.12" | |
| derive_generic_visitor = "0.3.0" | ||
| pastey = "0.1.0" | ||
| camino = "1.1.11" | ||
| capitalize = "0.3.4" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not bring an extra dependency for such a small utility function, just add it to as an helper somewhere (e.g. in a
helper.rsfile)