Allow Criterion group separator in name #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keks
approved these changes
May 26, 2025
Member
keks
left a comment
keks
left a comment
There was a problem hiding this comment.
I think this looks good, let's get this in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small improvement to the benchmark name format that is accepted by this action. Specifically, this PR adapts the format parsing to allow for one
/separator between thekey=valueentries in the name, to indicate which keys correspond to a Criterion group, and therefore to match the output format of Criterion benchmarks that are built using groups.The PR also adds test cases and data for this new functionality.
This PR also includes a bugfix for the release script, which avoids
git rm -rfreturning an error when node_modules have not been added to a branch yet.