Skip to content

Make some methods public in Cryptor #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jeyries
Copy link

@jeyries jeyries commented Nov 16, 2022

This will open the cryptolib-swift library, for example for providing external Streams support

@tobihagemann
Copy link
Member

I'm very sorry that I'm nitpicky about this but I wouldn't want to introduce breaking changes to the API if I'd have to revert this after the refactoring mentioned in #11. I don't have the full picture yet but I believe that the consumer of this API doesn't have to worry about the file header or even encrypting/decrypting single chunks. The changes have to be cohesive with the rest.

Since you have a very explicit use case and you already have a working solution, which is absolutely fine for you for now, you can just use your fork. We're actually doing this a lot and it's very straightforward with SPM. I understand that you'd prefer to have your changes upstream and I'm thankful for your contribution. If you want, I can give you a ping when I've implemented something that might be useful to you. I still think that your idea makes sense, it's just a question of API design that fits with the rest.

@jeyries
Copy link
Author

jeyries commented Nov 16, 2022

Hi Tobias, sure I am currently using my own fork of cryptolib-swift .

This was just a matter of contributing to this open source library .

Let's keep in touch if you add support for Streams in cryptolib-swift ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants