CI Update: Use macOS 14 runner #29
Conversation
WalkthroughThe recent updates focus on enhancing the development environment and codebase for a project. The changes include upgrading the macOS version and Xcode in the CI/CD pipeline, updating essential GitHub Actions, incorporating SwiftLint for code quality checks, and refining the build and test commands. Additionally, the codebase is improved by ensuring the necessary import of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/build.yml (2 hunks)
- Sources/CryptomatorCloudAccess/Dropbox/DropboxSetup.swift (1 hunks)
Additional comments: 6
Sources/CryptomatorCloudAccess/Dropbox/DropboxSetup.swift (1)
- 7-7: The addition of
import Foundationis standard practice in Swift development for accessing fundamental data types and functionalities, especially in a context likeDropboxSetupthat likely involves networking and data handling..github/workflows/build.yml (5)
- 9-9: Updating the runner to
macos-14aligns with the PR's objective to leverage the latest macOS version and the M1 macOS Runner's capabilities. This should enhance the CI process by utilizing the latest hardware and software advancements.- 15-16: Upgrading
actions/checkoutandactions/cacheto version 4 ensures the workflow benefits from the latest features and improvements in these actions. It's important to keep these actions up-to-date for efficiency and security reasons.- 22-23: The addition of SwiftLint installation via
brew install swiftlintaddresses the absence of SwiftLint in the macOS Sonoma image. This step ensures that linting checks continue to be part of the CI process, which is crucial for maintaining code quality and style consistency.- 28-29: Explicitly setting the Xcode version to 15.2 with
sudo xcode-select -s /Applications/Xcode_15.2.appensures consistency and compatibility with the project's requirements. This step is essential for a reliable CI process, as it guarantees the use of the correct Xcode version.- 28-29: Adjustments to the Xcode build and test commands, as well as the update to
macos-14for the release job, are correctly implemented to align with the new CI environment setup. These changes are necessary for leveraging the latest macOS and Xcode versions, ensuring the CI process is optimized for performance and compatibility.Also applies to: 66-66
On January 30, 2024, Github introduced the macOS Sonoma image and made it possible to use M1 macOS Runner.
As before the runner is available for free in public repositories:
In addition I've did minor upgrades to the used actions:
actions/checkouttov4actions/cachetov4Explicitly set the used Xcode version to
15.2.The only downside is that the new arm64 based image does not have SwiftLint pre-installed therefore I've added an additional step.
Basically the same as with: cryptomator/ios#339
The only difference is that I needed to fix a SwiftFormat linter warning because otherwise the CI would not pass.
Summary by CodeRabbit
Chores
New Features