Skip to content

fix(rpc): align eth_getLogs response with execution-apis spec#969

Merged
songgaoye merged 6 commits into
developfrom
song/fix_eth_getLogs
May 28, 2026
Merged

fix(rpc): align eth_getLogs response with execution-apis spec#969
songgaoye merged 6 commits into
developfrom
song/fix_eth_getLogs

Conversation

@songgaoye
Copy link
Copy Markdown

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@songgaoye songgaoye requested a review from a team as a code owner May 27, 2026 10:18
@songgaoye songgaoye requested review from calvinaco and thomas-nguy and removed request for a team May 27, 2026 10:18
@github-actions

This comment has been minimized.

@songgaoye songgaoye marked this pull request as draft May 27, 2026 10:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.84%. Comparing base (0506b9c) to head (686b1e8).

Files with missing lines Patch % Lines
rpc/namespaces/ethereum/eth/filters/filters.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #969      +/-   ##
===========================================
+ Coverage    44.74%   44.84%   +0.10%     
===========================================
  Files          197      197              
  Lines        16944    16952       +8     
===========================================
+ Hits          7581     7602      +21     
+ Misses        8555     8538      -17     
- Partials       808      812       +4     
Files with missing lines Coverage Δ
rpc/namespaces/ethereum/eth/filters/filters.go 41.04% <77.77%> (+10.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@songgaoye songgaoye marked this pull request as ready for review May 28, 2026 10:49
@songgaoye songgaoye merged commit 30214c2 into develop May 28, 2026
41 of 43 checks passed
@songgaoye songgaoye deleted the song/fix_eth_getLogs branch May 28, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants