Problem: missing property-base testing (fix #857)#862
Open
leejw51crypto wants to merge 4 commits into
Open
Conversation
leejw51crypto
requested review from
calvinaco and
crypto-matto
as code owners
tomtau
reviewed
Dec 6, 2021
| import sdk from '@crypto-org-chain/chain-jslib'; | ||
| import { Units, Secp256k1KeyPair } from '../../utils/ChainJsLib'; | ||
|
|
||
| test('should declare coin in ledger correctly', () => { |
Contributor
There was a problem hiding this comment.
what's the property here? cro.Coin not throwing an exception?
Contributor
Author
There was a problem hiding this comment.
whether coin can be created to the maximum, that will not throw any exception
tomtau
reviewed
Dec 6, 2021
| }, | ||
| phrase, | ||
| ); | ||
| expect(transferTxSignedHex !== '').to.eq(true); |
Contributor
There was a problem hiding this comment.
could also check transferTxSignedHex can be parsed into a transaction?
Contributor
|
There are also some |
Contributor
Author
|
fixing lint issue |
leejw51crypto
force-pushed
the
feature/857
branch
2 times, most recently
from
9f199ae to
5c6a7fb
Compare
add fast-check testing add tx rlp decoding tidy up fix lint and tidy up fix lint remove else
leejw51crypto
force-pushed
the
feature/857
branch
from
9c2619c to
36a7219
Compare
Frankramos181422
approved these changes
Jan 26, 2022
Frankramos181422
approved these changes
Jan 26, 2022
Frankramos181422
approved these changes
Oct 24, 2022
Frankramos181422
approved these changes
Oct 24, 2022
| ); | ||
| const decodedTransaction = RLP.decode(transferTxSignedHex); | ||
| expect(transferTxSignedHex !== '').to.eq(true); | ||
| expect(BigInt(decodedTransaction[4]) === amount).to.eq(true); |
| }, | ||
| phrase, | ||
| ); | ||
| expect(transferTxSignedHex !== '').to.eq(true); |
| }, | ||
| phrase, | ||
| ); | ||
| const decodedTransaction = RLP.decode(transferTxSignedHex); |
| phrase, | ||
| ); | ||
| const decodedTransaction = RLP.decode(transferTxSignedHex); | ||
| expect(transferTxSignedHex !== '').to.eq(true); |
Frankramos181422
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add fast-check testing