Skip to content

Problem: formatting in eth.models#1469

Open
bjormgyg wants to merge 1 commit into
crypto-com:devfrom
bjormgyg:patch-1
Open

Problem: formatting in eth.models#1469
bjormgyg wants to merge 1 commit into
crypto-com:devfrom
bjormgyg:patch-1

Conversation

@bjormgyg
Copy link
Copy Markdown

Missing semicolon after the object type definition for from_metadata. TypeScript interface properties should end with semicolons for consistency with the rest of the file. The same issue exists for to_metadata on line 44-46.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Have you rebased your work on top of the latest dev?
  • Does your PR follow the Conventional Commits Guide?
  • Have you checked your code compiles? (yarn build)
  • Have you included tests for any non-trivial functionality?
  • Have you followed the Multi-Language Content Management Guide?
  • Have you checked your code passes the unit tests? (yarn test)
  • Have you checked your code formatting is correct? (yarn lint:js)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (yarn audit)
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Missing semicolon after the object type definition for `from_metadata`. TypeScript interface properties should end with semicolons for consistency with the rest of the file. The same issue exists for `to_metadata` on line 44-46.


Signed-off-by: Björm Rusdianto <[email protected]>
@bjormgyg bjormgyg requested a review from a team as a code owner May 18, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant