Skip to content

#4 Secure pseudo-random generation on Windows #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
battila7 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#4 Secure pseudo-random generation on Windows #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/util/RandBytes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,16 @@

#if defined(_WIN32)

CryptidStatus cryptid_randomBytes(unsigned char *buf, int num)
#include <windows.h>
#include <bcrypt.h>

CryptidStatus cryptid_randomBytes(unsigned char *buf, const int num)
{
// TODO Implement Windows secure random generation.
// Issue with good-first-issue tag?
return CRYPTID_RANDOM_GENERATION_ERROR;
const NT_STATUS status = BCryptGenRandom(NULL, buf, num, BCRYPT_USE_SYSTEM_PREFERRED_RNG);

return status == STATUS_SUCCESS
? CRYPTID_SUCCESS
: CRYPTID_RANDOM_GENERATION_ERROR;
}

#elif defined(__CRYPTID_EXTERN_RANDOM)
Expand Down