Skip to content

fix(oxlint): allow async/await, raise function size limits (v0.1.5) - #8

Merged
akellbl4 merged 1 commit into
mainfrom
release/v0.1.5
Oct 8, 2026
Merged

akellbl4 merged 1 commit into
mainfrom
release/v0.1.5

Conversation

@akellbl4

@akellbl4 akellbl4 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Changes three rules in both shared Oxlint presets and releases the packages as 0.1.5.

  • oxc/no-async-await off. async/await is the normal way to write async code here; the rule flagged 500+ functions in sousvide.
  • eslint/max-lines-per-function: 100 lines, blank lines and comments not counted (default 50, counting both).
  • eslint/max-statements: 30 (default 10).

Request: https://github.com/crutchcrew/sousevide-alpha/pull/395#discussion_r4220384503 ("disable oxc/no-async-await, increase to a reasonable amount max-lines-per-function / max-statements").

Why these limits. Measured on sousvide with every inline suppression stripped:

Limit Functions over it
max-lines-per-function 50 / 75 / 100 / 150 79 / 31 / 16 / 5
max-statements 10 / 20 / 25 / 30 / 40 152 / 41 / 29 / 17 / 4

At 100 and 30 only the genuinely large functions stay flagged. The *.spec override keeps both size rules off for tests, as before. configg's own config drops its now-redundant oxc/no-async-await override.

Validation: bun run check, bun run version:check (all manifests at 0.1.5), bunx tsc --noEmit and bun run publish:packages --dry-run pass. Nothing was published locally.

Merging this release/v* branch tags v0.1.5 and triggers the publish workflow.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • The lint preset no longer flags async/await usage.
    • The lint preset now warns when functions exceed 100 lines (excluding blank lines and comments) or 30 statements.
    • Updated the preset documentation to reflect these rules.
    • Updated package versions to 0.1.5.

oxc/no-async-await is off in both presets. eslint/max-lines-per-function
allows 100 lines (blank lines and comments not counted) and
eslint/max-statements 30, so only genuinely large functions are flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: faf744d6-a802-4300-b3d7-92bea064bb72
📥 Commits

Reviewing files that changed from the base of the PR and between 946389f and aa400bc.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • oxlint.config.ts
  • package.json
  • packages/oxc/README.md
  • packages/oxc/package.json
  • packages/oxc/src/lint.ts
  • packages/tsconfig/package.json
 __________________________________
< Bazinga! You missed a semicolon. >
 ----------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@akellbl4
akellbl4 merged commit 16bced7 into main Oct 8, 2026
1 of 2 checks passed
@akellbl4
akellbl4 deleted the release/v0.1.5 branch October 8, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant