Repository navigation
fix(oxlint): allow async/await, raise function size limits (v0.1.5) - #8
Merged
Merged
Conversation
oxc/no-async-await is off in both presets. eslint/max-lines-per-function allows 100 lines (blank lines and comments not counted) and eslint/max-statements 30, so only genuinely large functions are flagged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes three rules in both shared Oxlint presets and releases the packages as 0.1.5.
oxc/no-async-awaitoff.async/awaitis the normal way to write async code here; the rule flagged 500+ functions in sousvide.eslint/max-lines-per-function: 100 lines, blank lines and comments not counted (default 50, counting both).eslint/max-statements: 30 (default 10).Request: https://github.com/crutchcrew/sousevide-alpha/pull/395#discussion_r4220384503 ("disable oxc/no-async-await, increase to a reasonable amount max-lines-per-function / max-statements").
Why these limits. Measured on sousvide with every inline suppression stripped:
max-lines-per-function50 / 75 / 100 / 150max-statements10 / 20 / 25 / 30 / 40At 100 and 30 only the genuinely large functions stay flagged. The
*.specoverride keeps both size rules off for tests, as before. configg's own config drops its now-redundantoxc/no-async-awaitoverride.Validation:
bun run check,bun run version:check(all manifests at 0.1.5),bunx tsc --noEmitandbun run publish:packages --dry-runpass. Nothing was published locally.Merging this
release/v*branch tags v0.1.5 and triggers the publish workflow.🤖 Generated with Claude Code
Summary by CodeRabbit