Skip to content

fix(oxlint): allow continue in shared presets (v0.1.8) - #11

Merged
akellbl4 merged 1 commit into
mainfrom
release/v0.1.8
Oct 8, 2026
Merged

akellbl4 merged 1 commit into
mainfrom
release/v0.1.8

Conversation

@akellbl4

@akellbl4 akellbl4 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Turns eslint/no-continue off in both shared Oxlint presets and releases the packages as 0.1.8. configg's own scripts/** override for the rule goes, since the presets cover it now.

Request: Paul asked to disable no-continue in configg (sousvide carries ~21 per-line suppressions for it).

Validation: bun run check, bun run version:check (all manifests at 0.1.8) and bun run publish:packages --dry-run pass. Nothing was published locally.

Already on main: bunx tsc --noEmit reports one error in packages/oxc/src/anti-slop/shared/dictionary-types.ts:201 (undefined is not assignable to the … | null return type). That file came in with #9 (v0.1.6) and this PR doesn't touch it. CI doesn't run tsc, so it went unnoticed.

Merging this release/v* branch tags v0.1.8 and triggers the publish workflow.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Linting
    • continue statements are now permitted by the shared lint rules and in scripts, making linting behavior consistent across the project.
  • Documentation
    • Updated the linter documentation to reflect that continue statements are allowed. Existing function-length and statement-count limits are unchanged.
  • Release
    • Updated the project and package versions to 0.1.8.

eslint/no-continue is off in both presets; configg's own scripts override
for it goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 767bb51d-c8c4-4e50-8f7f-1393cd8d5e1c
📥 Commits

Reviewing files that changed from the base of the PR and between 200c87d and 37d639f.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • oxlint.config.ts
  • package.json
  • packages/oxc/README.md
  • packages/oxc/package.json
  • packages/oxc/src/lint.ts
  • packages/tsconfig/package.json
💤 Files with no reviewable changes (1)
  • oxlint.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The shared Oxlint rules now disable eslint/no-continue, and the scripts override no longer sets that rule. The linter README reflects this setting. The root, @configg/oxc, and @configg/tsconfig package versions change to 0.1.8.

Changes

Oxlint rule and package update

Layer / File(s) Summary
Set and document the continue rule
packages/oxc/src/lint.ts, oxlint.config.ts, packages/oxc/README.md
The shared Oxlint rules disable eslint/no-continue. The scripts override no longer sets the rule. The README states that continue is allowed.
Update package versions
package.json, packages/oxc/package.json, packages/tsconfig/package.json
The three package versions change from 0.1.7 to 0.1.8.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 37d63

The change intentionally allows continue under the shared lint policy and aligns the package versions at 0.1.8. The supplied evidence identifies no concrete issue that should block merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 37d63

The change affects 4 systems.

Changed systems: packages/oxc, oxlint.config.ts, package.json, packages/tsconfig

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/oxc (library) was modified; 3 changed files map to changed impact.
  • observed — oxlint.config.ts (service) was modified; 1 changed file maps to changed impact.
  • observed — package.json (service) was modified; 1 changed file maps to changed impact.
  • observed — packages/tsconfig (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in oxlint.config.ts: The scripts/** override no longer sets eslint/no-continue to off; the rule now follows the other applicable configuration.
  • observed — Modified behavior in package.json: The package version changed from 0.1.7 to 0.1.8.
  • observed — Modified behavior in packages/oxc/README.md: The linter guidance now says continue is allowed because eslint/no-continue is off; the existing 100-line and 30-statement function limits remain.
  • observed — Modified behavior in packages/oxc/package.json: The package version changes from 0.1.7 to 0.1.8.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: allowing continue in shared Oxlint presets. The version identifier is also accurate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@akellbl4
akellbl4 merged commit b08bf60 into main Oct 8, 2026
2 checks passed
@akellbl4
akellbl4 deleted the release/v0.1.8 branch October 8, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant