Repository navigation
fix(oxlint): allow continue in shared presets (v0.1.8) - #11
Conversation
eslint/no-continue is off in both presets; configg's own scripts override for it goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe shared Oxlint rules now disable ChangesOxlint rule and package update
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change intentionally allows Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 4 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Turns
eslint/no-continueoff in both shared Oxlint presets and releases the packages as 0.1.8. configg's ownscripts/**override for the rule goes, since the presets cover it now.Request: Paul asked to disable
no-continuein configg (sousvide carries ~21 per-line suppressions for it).Validation:
bun run check,bun run version:check(all manifests at 0.1.8) andbun run publish:packages --dry-runpass. Nothing was published locally.Already on main:
bunx tsc --noEmitreports one error inpackages/oxc/src/anti-slop/shared/dictionary-types.ts:201(undefinedis not assignable to the… | nullreturn type). That file came in with #9 (v0.1.6) and this PR doesn't touch it. CI doesn't runtsc, so it went unnoticed.Merging this
release/v*branch tags v0.1.8 and triggers the publish workflow.🤖 Generated with Claude Code
Summary by CodeRabbit
continuestatements are now permitted by the shared lint rules and in scripts, making linting behavior consistent across the project.continuestatements are allowed. Existing function-length and statement-count limits are unchanged.