Repository navigation
feat(oxlint): make anti-slop rules opt-in (v0.1.7) - #10
Conversation
The presets no longer enable anti-slop. `antiSlop` (exported next to `configs`) carries the plugin entry and all 18 rules as errors, plus `unicorn/prefer-reflect-apply` off; a project opts in by spreading its `jsPlugins` and `rules` into a preset. configg's own lint opts in, so the vendored plugin stays exercised. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughOxlint client and scripts configs no longer enable anti-slop by default. The Oxlint package exports an opt-in preset with the anti-slop plugin and rules. The repository’s Oxlint config opts into that preset. Documentation and package versions are updated. ChangesOxlint anti-slop preset
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to Anti-slop is now opt-in for consumers, while the repository retains it in its own lint configuration. The supplied evidence shows no merge-blocking regression. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Follow-up to #9: the presets no longer turn anti-slop on; projects opt in.
What changed
lint.ts: the 18anti-slop/*rules andunicorn/prefer-reflect-apply: 'off'move out ofsharedRules, and both presets drop the plugin fromjsPlugins. A new export,antiSlop, holds{ jsPlugins: [anti-slop plugin], rules: { …18 rules as error, 'unicorn/prefer-reflect-apply': 'off' } }.oxlint.config.tsopts in, so the vendored plugin stays exercised in CI.Checks
bun run check(fmt, lint, frozen lockfile) andversion:check: passoxlint --report-unused-disable-directives: clean; the existing anti-slop suppression inscripts/manifest.tsstill counts as used, so the opt-in loads the pluginconfigs.client/configs.scriptscarry nojsPluginsand noanti-slop/*rules🤖 Generated with Claude Code
Summary by CodeRabbit