Skip to content

feat(oxlint): make anti-slop rules opt-in (v0.1.7) - #10

Merged
akellbl4 merged 1 commit into
mainfrom
release/v0.1.7
Oct 8, 2026
Merged

akellbl4 merged 1 commit into
mainfrom
release/v0.1.7

Conversation

@akellbl4

@akellbl4 akellbl4 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #9: the presets no longer turn anti-slop on; projects opt in.

What changed

  • lint.ts: the 18 anti-slop/* rules and unicorn/prefer-reflect-apply: 'off' move out of sharedRules, and both presets drop the plugin from jsPlugins. A new export, antiSlop, holds { jsPlugins: [anti-slop plugin], rules: { …18 rules as error, 'unicorn/prefer-reflect-apply': 'off' } }.
  • Opting in:
    import { antiSlop, configs } from '@configg/bases/oxlint'
    
    export default defineConfig({
    	...configs.client,
    	jsPlugins: [...antiSlop.jsPlugins],
    	rules: { ...configs.client.rules, ...antiSlop.rules },
    })
  • configg's own oxlint.config.ts opts in, so the vendored plugin stays exercised in CI.
  • READMEs describe the opt-in; version 0.1.7.

Checks

  • bun run check (fmt, lint, frozen lockfile) and version:check: pass
  • oxlint --report-unused-disable-directives: clean; the existing anti-slop suppression in scripts/manifest.ts still counts as used, so the opt-in loads the plugin
  • configs.client/configs.scripts carry no jsPlugins and no anti-slop/* rules

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration Changes
    • Oxlint presets no longer enable anti-slop rules by default. Enable the separate anti-slop preset to use them, and retain its plugin when supplying a custom plugin list.
  • Documentation
    • Updated setup guidance with examples for combining anti-slop with client configuration and notes on running Oxlint with Bun.

The presets no longer enable anti-slop. `antiSlop` (exported next to
`configs`) carries the plugin entry and all 18 rules as errors, plus
`unicorn/prefer-reflect-apply` off; a project opts in by spreading its
`jsPlugins` and `rules` into a preset. configg's own lint opts in, so the
vendored plugin stays exercised.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 433288dc-3b41-43f4-a5b5-0116fc11de85
📥 Commits

Reviewing files that changed from the base of the PR and between 829ddcc and f4d38c2.

📒 Files selected for processing (7)
  • README.md
  • oxlint.config.ts
  • package.json
  • packages/oxc/README.md
  • packages/oxc/package.json
  • packages/oxc/src/lint.ts
  • packages/tsconfig/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Oxlint client and scripts configs no longer enable anti-slop by default. The Oxlint package exports an opt-in preset with the anti-slop plugin and rules. The repository’s Oxlint config opts into that preset. Documentation and package versions are updated.

Changes

Oxlint anti-slop preset

Layer / File(s) Summary
Define the opt-in preset
packages/oxc/src/lint.ts
The package exports antiSlop, which registers the anti-slop plugin and enables its rules. The client and scripts configs no longer register the plugin directly.
Use and document the preset
oxlint.config.ts, README.md, packages/oxc/README.md, package.json, packages/oxc/package.json, packages/tsconfig/package.json
The repository config combines the preset’s plugins and rules with the scripts config. The README files document opt-in use. The three package versions change to 0.1.7.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to f4d38

Anti-slop is now opt-in for consumers, while the repository retains it in its own lint configuration. The supplied evidence shows no merge-blocking regression.

Architecture Summary

Architecture risk: 🔵 Low · up to f4d38

The change affects 5 systems.

Changed systems: packages/oxc, oxlint.config.ts, package.json, packages/tsconfig, README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/oxc (library) was modified; 3 changed files map to changed impact.
  • observed — oxlint.config.ts (service) was modified; 1 changed file maps to changed impact.
  • observed — package.json (service) was modified; 1 changed file maps to changed impact.
  • observed — packages/tsconfig (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: The documentation changes anti-slop from enabled in both Oxlint presets to opt-in via the antiSlop export. It describes the plugin and all 18 rules as errors, notes that unicorn/prefer-reflect-apply is off, and adds a configs.client example that merges the anti-slop plugin and rules. It also says to preserve the anti-slop entry when supplying a custom jsPlugins array; the Bun runtime guidance remains.
  • observed — Modified behavior in oxlint.config.ts: The config now imports antiSlop and registers its JavaScript plugins; previously it imported only configs and did not set jsPlugins.
  • observed — Modified behavior in oxlint.config.ts: The configured rules now combine configs.scripts.rules with antiSlop.rules.
  • observed — Modified behavior in package.json: The package version changes from 0.1.6 to 0.1.7.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: anti-slop rules become opt-in for Oxlint, with the package version updated to 0.1.7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@akellbl4
akellbl4 merged commit 200c87d into main Oct 8, 2026
2 checks passed
@akellbl4
akellbl4 deleted the release/v0.1.7 branch October 8, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant