[build-properties] enable network inspector by default (expo#22994)

# Why

for sdk 49, let's enable network inspector by default

# How

- rename `unstable_networkInspector` to `networkInspector`
- enable the property by default
- update generated doc

# Test Plan

- ci passed
- tested prebuild on real project

packages/expo-build-properties/CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### 🛠 Breaking changes
 
+- Replaced `unstable_networkInspector` as `networkInspector` and enabled the feature by default. ([#22994](https://github.com/expo/expo/pull/22994) by [@kudo](https://github.com/kudo))
+
 ### 🎉 New features
 
 - Added `android.extraMavenRepos` and `ios.extraPods` support. ([#22785](https://github.com/expo/expo/pull/22785) by [@kudo](https://github.com/kudo))

packages/expo-build-properties/src/__tests__/android-test.ts

@@ -118,12 +118,10 @@ describe(withAndroidFlipper, () => {
         modResults: [{ type: 'property', key: 'android.flipper', value: '0.999.0' }],
       }
     );
-    expect(androidModResults).toEqual([
-      {
-        type: 'property',
-        key: 'android.flipper',
-        value: '0.999.0',
-      },
-    ]);
+    expect(androidModResults).toContainEqual({
+      type: 'property',
+      key: 'android.flipper',
+      value: '0.999.0',
+    });
   });
 });

packages/expo-build-properties/src/__tests__/withBuildProperties-test.ts

@@ -87,13 +87,11 @@ describe(withBuildProperties, () => {
         modResults: [{ type: 'property', key: 'android.compileSdkVersion', value: '30' }],
       }
     );
-    expect(androidModResults).toEqual([
-      {
-        type: 'property',
-        key: 'android.compileSdkVersion',
-        value: '31',
-      },
-    ]);
+    expect(androidModResults).toContainEqual({
+      type: 'property',
+      key: 'android.compileSdkVersion',
+      value: '31',
+    });
 
     const { modResults: iosModResults } = await compileMockModWithResultsAsync(
       {},
@@ -104,7 +102,7 @@ describe(withBuildProperties, () => {
         modResults: { 'ios.useFrameworks': 'dynamic' } as Record<string, string>,
       }
     );
-    expect(iosModResults).toEqual({
+    expect(iosModResults).toMatchObject({
       'ios.useFrameworks': 'static',
     });
   });
@@ -121,13 +119,11 @@ describe(withBuildProperties, () => {
         modResults: [{ type: 'property', key: 'android.compileSdkVersion', value: '30' }],
       }
     );
-    expect(androidModResults).toEqual([
-      {
-        type: 'property',
-        key: 'android.compileSdkVersion',
-        value: '30',
-      },
-    ]);
+    expect(androidModResults).toContainEqual({
+      type: 'property',
+      key: 'android.compileSdkVersion',
+      value: '30',
+    });
 
     const { modResults: iosModResults } = await compileMockModWithResultsAsync(
       {},
@@ -138,7 +134,7 @@ describe(withBuildProperties, () => {
         modResults: { 'ios.useFrameworks': 'dynamic' } as Record<string, string>,
       }
     );
-    expect(iosModResults).toEqual({
+    expect(iosModResults).toMatchObject({
       'ios.useFrameworks': 'dynamic',
     });
   });

packages/expo-build-properties/src/android.ts

@@ -65,7 +65,7 @@ export const withAndroidBuildProperties = createBuildGradlePropsConfigPlugin<Plu
     },
     {
       propName: 'EX_DEV_CLIENT_NETWORK_INSPECTOR',
-      propValueGetter: (config) => config.android?.unstable_networkInspector?.toString(),
+      propValueGetter: (config) => (config.android?.networkInspector ?? true).toString(),
     },
   ],
   'withAndroidBuildProperties'

packages/expo-build-properties/src/ios.ts

@@ -25,7 +25,7 @@ export const withIosBuildProperties = createBuildPodfilePropsConfigPlugin<Plugin
     },
     {
       propName: 'EX_DEV_CLIENT_NETWORK_INSPECTOR',
-      propValueGetter: (config) => config.ios?.unstable_networkInspector?.toString(),
+      propValueGetter: (config) => (config.ios?.networkInspector ?? true).toString(),
     },
   ],
   'withIosBuildProperties'

packages/expo-build-properties/src/pluginConfig.ts

@@ -90,10 +90,11 @@ export interface PluginConfigTypeAndroid {
   flipper?: string;
 
   /**
-   * Enable the experimental Network Inspector for [Development builds](https://docs.expo.dev/develop/development-builds/introduction/).
-   * SDK 49+ is required.
+   * Enable the Network Inspector.
+   *
+   * @default true
    */
-  unstable_networkInspector?: boolean;
+  networkInspector?: boolean;
 
   /**
    * Add extra maven repositories to all gradle projects.
@@ -152,10 +153,11 @@ export interface PluginConfigTypeIos {
   flipper?: boolean | string;
 
   /**
-   * Enable the experimental Network Inspector for [Development builds](https://docs.expo.dev/develop/development-builds/introduction/).
-   * SDK 49+ is required.
+   * Enable the Network Inspector.
+   *
+   * @default true
    */
-  unstable_networkInspector?: boolean;
+  networkInspector?: boolean;
 
   /**
    * Add extra CocoaPods dependencies for all targets.
@@ -302,7 +304,7 @@ const schema: JSONSchemaType<PluginConfigType> = {
           nullable: true,
         },
 
-        unstable_networkInspector: { type: 'boolean', nullable: true },
+        networkInspector: { type: 'boolean', nullable: true },
 
         extraMavenRepos: { type: 'array', items: { type: 'string' }, nullable: true },
       },
@@ -320,7 +322,7 @@ const schema: JSONSchemaType<PluginConfigType> = {
           nullable: true,
         },
 
-        unstable_networkInspector: { type: 'boolean', nullable: true },
+        networkInspector: { type: 'boolean', nullable: true },
 
         extraPods: {
           type: 'array',