[constants] Remove deprecated fields (expo#23068)

# Why `model` and `deviceYearClass` were slated to be removed in SDK 45. We left them around for a bit longer. G'bye # How Delete JS and native code, re-generate docs schema. # Test Plan CI - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). --------- Co-authored-by: Expo Bot <[email protected]>
crummy · Jun 24, 2023 · e6258d3 · e6258d3
1 parent a321dcb
commit e6258d3
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 385 deletions.
diff --git a/apps/test-suite/tests/Constants.js b/apps/test-suite/tests/Constants.js
@@ -21,7 +21,6 @@ export function test(t) {
     );
     [
       'deviceName',
-      'deviceYearClass',
       'installationId',
       'isDevice',
       'sessionId',

diff --git a/docs/public/static/data/unversioned/expo-constants.json b/docs/public/static/data/unversioned/expo-constants.json
diff --git a/packages/expo-constants/CHANGELOG.md b/packages/expo-constants/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### 💡 Others
 
+- Remove the long-deprecated `Constants.deviceYearClass` and `Constants.platform.ios.model`. These properties now live on `expo-device`. ([#23068](https://github.com/expo/expo/pull/23068) by [@brentvatne](https://github.com/brentvatne))
+
 ## 14.4.1 — 2023-06-22
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-constants/android/build.gradle b/packages/expo-constants/android/build.gradle
@@ -88,7 +88,6 @@ repositories {
 dependencies {
   implementation project(':expo-modules-core')
 
-  api 'com.facebook.device.yearclass:yearclass:2.1.0'
   api "androidx.annotation:annotation:1.0.0"
   implementation "commons-io:commons-io:2.6"
 

diff --git a/packages/expo-constants/android/src/main/java/expo/modules/constants/ConstantsService.kt b/packages/expo-constants/android/src/main/java/expo/modules/constants/ConstantsService.kt
@@ -2,8 +2,6 @@ package expo.modules.constants
 
 import org.apache.commons.io.IOUtils
 
-import com.facebook.device.yearclass.YearClass
-
 import expo.modules.core.interfaces.InternalModule
 import expo.modules.core.utilities.EmulatorUtilities
 import expo.modules.interfaces.constants.ConstantsInterface
@@ -45,7 +43,6 @@ open class ConstantsService(private val context: Context) : InternalModule, Cons
       "sessionId" to sessionId,
       "executionEnvironment" to ExecutionEnvironment.BARE.string,
       "statusBarHeight" to statusBarHeightInternal,
-      "deviceYearClass" to deviceYearClass,
       "deviceName" to deviceName,
       "isDevice" to isDevice,
       "systemFonts" to systemFonts,
@@ -75,8 +72,6 @@ open class ConstantsService(private val context: Context) : InternalModule, Cons
 
   override fun getDeviceName(): String = Build.MODEL
 
-  override fun getDeviceYearClass() = YearClass.get(context)
-
   override fun getIsDevice() = !EmulatorUtilities.isRunningOnEmulator()
 
   override fun getStatusBarHeight() = statusBarHeightInternal

diff --git a/packages/expo-constants/build/Constants.d.ts.map b/packages/expo-constants/build/Constants.d.ts.map
diff --git a/packages/expo-constants/build/Constants.js b/packages/expo-constants/build/Constants.js
diff --git a/packages/expo-constants/build/Constants.js.map b/packages/expo-constants/build/Constants.js.map
diff --git a/packages/expo-constants/ios/EXConstantsService.h b/packages/expo-constants/ios/EXConstantsService.h
@@ -21,7 +21,6 @@ FOUNDATION_EXPORT NSString * const EXConstantsExecutionEnvironmentStoreClient;
 - (NSArray<NSString *> *)systemFontNames;
 
 + (NSString *)devicePlatform;
-+ (nullable NSString *)deviceModel;
 + (NSNumber *)deviceYear;
 + (NSString *)deviceName;