Skip to content

Commit

Permalink
[ci][android] fix versioned expo go build error (expo#22802)
Browse files Browse the repository at this point in the history
# Why

regression from expo#22107
this happens only on versioned variant: https://github.com/expo/expo/actions/runs/5206380027/jobs/9392879045

# How

- backport necessary dependency to sdk 47/48 code.
- though it's unrelated, also bump default ndk version in our cache. we now build from ndk r23. original ndk r21 will always be cache missed.

# Test Plan

`./gradlew :app:assembleVersionedDebug`
  • Loading branch information
Kudo authored Jun 14, 2023
1 parent 9d0e721 commit db56e41
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/actions/expo-caches/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ inputs:
required: false
ndk-version:
description: 'NDK version used'
default: '21.4.7075529'
default: '23.1.7779620'
required: false
git-lfs:
description: 'Restore Git LFS cache'
Expand Down
4 changes: 4 additions & 0 deletions android/versioned-abis/expoview-abi47_0_0/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ dependencies {
// expo-application
api 'com.android.installreferrer:installreferrer:1.0'

// expo-barcode-scanner
implementation "com.google.android.gms:play-services-vision:19.0.0"
implementation "com.google.zxing:core:3.3.3"

// expo-store-review
implementation "com.google.android.play:review:2.0.1"
implementation "com.google.android.play:review-ktx:2.0.0"
Expand Down
4 changes: 4 additions & 0 deletions android/versioned-abis/expoview-abi48_0_0/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ dependencies {
// expo-application
api 'com.android.installreferrer:installreferrer:1.0'

// expo-barcode-scanner
implementation "com.google.android.gms:play-services-vision:19.0.0"
implementation "com.google.zxing:core:3.3.3"

// expo-store-review
implementation "com.google.android.play:review:2.0.1"
implementation "com.google.android.play:review-ktx:2.0.0"
Expand Down

0 comments on commit db56e41

Please sign in to comment.