userCallback() - #14
Open
embedded-creations wants to merge 1 commit into
Open
Conversation
Owner
|
I'll consider it, thanks for the suggestion! My first pick would probably be to put it into a chip select class, so that the callback is called when a chip is deselected. Your approach is a bit more general (and thus more flexible), but adds overhead to all transfers including those that don't need a callback. |
Author
|
True, but it's not much overhead to check for a null pointer. In my use case, I'm not using a chip select, I'm driving an APA102 LED strip that only needs CLK and TX pins. It might be useful to associate the callback with a transaction and not with every transfer. I could see someone wanting a callback only on the last transfer when queueing up several. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a callback function to know when my transfer had completed, maybe others could use this as well?