Skip to content

userCallback() - #14

Open
embedded-creations wants to merge 1 commit into
crteensy:masterfrom
pixelmatix:userCallback
Open

userCallback()#14
embedded-creations wants to merge 1 commit into
crteensy:masterfrom
pixelmatix:userCallback

Conversation

@embedded-creations

Copy link
Copy Markdown

I needed a callback function to know when my transfer had completed, maybe others could use this as well?

@crteensy

Copy link
Copy Markdown
Owner

I'll consider it, thanks for the suggestion!

My first pick would probably be to put it into a chip select class, so that the callback is called when a chip is deselected. Your approach is a bit more general (and thus more flexible), but adds overhead to all transfers including those that don't need a callback.

@embedded-creations

Copy link
Copy Markdown
Author

True, but it's not much overhead to check for a null pointer. In my use case, I'm not using a chip select, I'm driving an APA102 LED strip that only needs CLK and TX pins.

It might be useful to associate the callback with a transaction and not with every transfer. I could see someone wanting a callback only on the last transfer when queueing up several.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants