Repository navigation
feat(library): add private spatial viewer experiment - #724
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (38)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds an experimental spatial viewer for selected Library links. It includes shared graph and flight utilities, desktop pairing controls, and a read-only HTTPS bridge for browser access. The viewer supports search, resource inspection, and WebXR interaction. Build configuration, tests, and documentation are also added. ChangesSpatial Library preview
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant SpatialPairing
participant xnet
participant setupSpatialLibraryIPC
participant createSpatialServer
participant createSpatialBridge
participant spatialMain
participant pairedAdapter
SpatialPairing->>xnet: Start with origin and selected link IDs
xnet->>setupSpatialLibraryIPC: Send spatial start IPC
setupSpatialLibraryIPC->>createSpatialBridge: Create bridge for scoped snapshot
setupSpatialLibraryIPC->>createSpatialServer: Start HTTPS listener
spatialMain->>pairedAdapter: Redeem invitation from URL hash
pairedAdapter->>createSpatialServer: POST /pair with invitation
createSpatialServer->>createSpatialBridge: Forward pairing request
createSpatialBridge-->>pairedAdapter: Return bearer token
pairedAdapter->>createSpatialServer: Request snapshot with bearer token
createSpatialServer->>createSpatialBridge: Forward authenticated read
createSpatialBridge-->>pairedAdapter: Return snapshot
Merge Risk: ⚪ Minimal · up to This adds an experimental spatial Library viewer and a scoped, expiring, read-only pairing path. No concrete merge-blocking defect was found. Physical headset behavior still needs to be checked on the device, as the description says. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 35 functions across 28 files. (10 skipped: 10 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 3 commits
October 6, 2026 10:35
- Reuse graph filtering, search and deterministic layout outside Electron preload. - Keep positions paired with snapshot revisions and resource identities. - Add explicit flight arming, analog acceleration, brakes and interruption rearming. - Verify frame-rate integration, invalid inputs and full-fixture searchability. Signed-off-by: xNet Test <test@xnet.dev>
- Exchange one-use invitations for expiring and revocable read-only capabilities. - Restrict reads to selected link snapshots, details and bounded thumbnails. - Exclude conversation records from graph projections and test verified TLS revocation. - Add the native pairing control and record the transport decision with a tripwire. Signed-off-by: xNet Test <test@xnet.dev>
- Provide searchable synthetic and paired snapshots with stable filters and evidence cards. - Add stationary overview, explicit travel, return history and guarded controller flight. - Bound labels, relationship lines and thumbnail loading; export hardware probe observations. - Document desktop verification and mark exploration 0468 partially implemented. - Keep physical device review and full-pose flight gates pending. Signed-off-by: xNet Test <test@xnet.dev>
crs48
force-pushed
the
codex/0468-spatial-library
branch
from
October 6, 2026 17:35
6891406 to
0892a35
Compare
Contributor
|
Preview removed for PR #724. |
crs48
marked this pull request as ready for review
October 6, 2026 19:41
added 2 commits
October 6, 2026 12:59
- Include the patched image decoder and refreshed documentation review dates. - Keep the spatial viewer experimental while hardware validation remains pending. Signed-off-by: xNet Test <test@xnet.dev>
- Regenerate the documentation export with the spatial pairing guide and ADR-47. - Verify the generated text matches all 63 source documentation pages. Signed-off-by: xNet Test <test@xnet.dev>
- Include the merged Library dependency before final hosted verification. Signed-off-by: xNet Test <test@xnet.dev>
- Keep the spatial branch current with the automatic post-merge documentation update. Signed-off-by: xNet Test <test@xnet.dev>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Library graph currently depends on Electron preload and a desktop camera. This adds an experimental browser viewer with search, source/group filters, stable metre-scale snapshots, metadata cards, and explicit destination travel. WebXR starts stationary; tracked position, rotation and analog range must be observed before controller flight can be armed, and interruption requires rearming with a released trigger.
The Mac can explicitly pair the current selection over trusted private HTTPS. A one-use invitation exchanges for a scoped, expiring read-only capability; revocation, origin/host checks, bounded thumbnails and conversation exclusion keep this separate from the local API and debugger. No identity replacement, test-auth bypass, public hosting or enrichment jobs are introduced.
Changelog
Added the experimental spatial viewer fragment; no syndication.
Verification
f22377779: 12,749 passed, four skipped; all 102 workspace build/typecheck tasks passed. Focused flight/snapshot/graph/privacy/TLS tests: 66 passed.Hosted verification on
f22377779: real CI lint, typecheck, all three test shards, editor UX, Electron smoke tests, conformance, and changelog checks pass. No unresolved review comments remain. The informational dependency audit still reports dependencies already present on main; its baseline is unchanged.Remaining release gates
This is an experimental implementation targeting main. Its Library dependency, #721, is merged. Exploration 0468 is marked partially implemented. No physical Vision Pro/Sense validation is claimed: actual controller exposure, pinch coexistence, interruption/re-entry behavior, trusted headset pairing, stereo performance/memory and Chris's comfort trial remain pending. Full-pose flight is deliberately gated on that review; native fallback and further rendering optimization depend on measured evidence.
See
apps/electron/src/spatial/README.mdfor the runbook anddocs/explorations/0468_[-]_VISION_PRO_SPATIAL_LIBRARY_GRAPH.mdfor the checked evidence and pending checklist. ADR-47 records the temporary pairing design and its tripwire.Docs & site sync
Summary by CodeRabbit