-
Notifications
You must be signed in to change notification settings - Fork 11
fix: resolve inherited profiles reporting issues and restore check skipping #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: resolve inherited profiles reporting issues and restore check skipping #141
Conversation
…sue reporting is disabled
…nly reporting (not loading) of inherited profiles
…ed_profiles_issue_reporting` is set
… disabled by default
| #: Flag to disable inherited profiles reporting | ||
| disable_inherited_profiles_reporting: bool = False | ||
| #: Flag to disable reporting of issues related to inherited profiles | ||
| disable_inherited_profiles_issue_reporting: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it would be useful if you could add a note to the changelog when something is renamed - changed names often create errors in our fork and having a clear changelog helps to figure out what we need to update without looking through individual PRs.
(Last week I was caught a bit off-guard by the move to utils.io_helpers!)
This pull request refines the validation behavior related to the renamed flag
disable_inherited_profiles_issue_reporting. The update ensures that when this flag is enabled, only issues from the main profile are reported, skipping checks from inherited profiles in both Python and SHACL validation (fix issue #135).In addition, the pull request also fixes issues that previously prevented specific checks from being skipped — both via the CLI and programmatically through the API (fix #126).
Tests workflows have been updated accordingly to verify the corrected behavior.