Skip to content

Conversation

@kikkomep
Copy link
Member

@kikkomep kikkomep commented Jan 9, 2026

This pull request refines the validation behavior related to the renamed flag disable_inherited_profiles_issue_reporting. The update ensures that when this flag is enabled, only issues from the main profile are reported, skipping checks from inherited profiles in both Python and SHACL validation (fix issue #135).

In addition, the pull request also fixes issues that previously prevented specific checks from being skipped — both via the CLI and programmatically through the API (fix #126).

Tests workflows have been updated accordingly to verify the corrected behavior.

@elichad
Copy link
Contributor

elichad commented Jan 12, 2026

Tested locally and I'm satisfied that this will fix #126 and #135, thanks @kikkomep!

(haven't reviewed the code)

#: Flag to disable inherited profiles reporting
disable_inherited_profiles_reporting: bool = False
#: Flag to disable reporting of issues related to inherited profiles
disable_inherited_profiles_issue_reporting: bool = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it would be useful if you could add a note to the changelog when something is renamed - changed names often create errors in our fork and having a clear changelog helps to figure out what we need to update without looking through individual PRs.
(Last week I was caught a bit off-guard by the move to utils.io_helpers!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skipping certain checks does not work

2 participants