Allow do_entity_test to accept arbitrary validation settings #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichad
changed the title
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of life improvement :) A couple of times now I have found myself wanting to be able to pass in validation settings that aren't explicitly listed as args in
do_entity_test. This is a small change that enables additional validation settings to be passed through easily.An example of how I would use this: https://github.com/eScienceLab/rocrate-validator/blob/0501f2ce1d9d5f5e5d4d9503c98391c2c4758cdf/tests/integration/profiles/five-safes-crate/test_valid_5src.py#L89
Some auto-fomatting changes were also made with
black. The lines I changed manually are just the ones wherekwargsare mentioned.