Contract improvements and rebranding#1
Open
TheLonelyDev wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contract has received some changes.
Cosmetic change: contract rebrand
Cleaned up the general code, removed abundant [[eosio::action]] statements. Refactored the code to not hook int apply but rather use the on_notify feature (cleaner approach).
"Breaking" changes ahead!
In order for the updated contract with token burning to work, this contract should be added under the active permissions of the token contract.
While using the token contract, go to https://wax.bloks.io/wallet/permissions/advanced collapse the active permission and add monkeymarket (the smart contract's address on mainnet) to the accounts list and hit save. Eg
Recommendation: recompile the eosio.token contract and upload this to the mainnet token contract instead of the old custom contract. Please keep in mind that this can only be done once the monkeysmatch contract has also been updated. Ref to the eosio.token contract: https://github.com/EOSIO/eosio.contracts/tree/master/contracts/eosio.token
We are now using the eosio permission system to its capacity instead of contract modifications :)