Skip to content

fix: corrected bad datetime json encoding when selecting jsonl format #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuromantik33 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: corrected bad datetime json encoding when selecting jsonl format #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb4436
fix: bad poetry.lock file
Jun 19, 2024
660546b
fix: correcting unserializable datetimes when using jsonl format
Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 5 additions & 12 deletions target_s3/formats/format_jsonl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
from datetime import datetime
from functools import partial

from bson import ObjectId
from simplejson import JSONEncoder, dumps
import simplejson as json

from target_s3.formats.format_base import FormatBase

from .format_json import JsonSerialize

class JsonSerialize(JSONEncoder):
def default(self, obj: any) -> any:
if isinstance(obj, ObjectId):
return str(obj)
if isinstance(obj, datetime):
return obj.isoformat()
else:
raise TypeError(f"Type {type(obj)} not serializable")
dumps = partial(json.dumps, cls=JsonSerialize)


class FormatJsonl(FormatBase):
Expand All @@ -26,7 +19,7 @@ def _prepare_records(self):
return super()._prepare_records()

def _write(self) -> None:
return super()._write('\n'.join(map(dumps, self.records)))
return super()._write("\n".join(map(dumps, self.records)))

def run(self) -> None:
# use default behavior, no additional run steps needed
Expand Down