feat: call SetupStream and SetupMetrics from nginx configuration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the unused stream mode setup and metrics setup from the ~allowIp~ and ~Allow~ functions to clean up the code.
Added a new function ~csmod.get_mode~ to retrieve the runtime mode from the configuration. This function returns the value of the ~MODE~ key from the ~runtime.conf~ table.
Expose the SetupMetrics and SetupStream functions to make them accessible outside the module.
Corrected the function reference in the timer setup from ~Setup_metrics~ to ~csmod.SetupMetrics~ to ensure proper execution of the timer.
…lization + Added ~init_worker_by_lua_block~ to initialize stream mode and metrics for workers. + Ensured that stream mode is set up for workers when mode is "stream". + Metrics initialization is performed only by worker 0.
Ensure the debug cache entries are in the correct order in `t/05stream_and_ban.t`.
buixor
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start the timers (SetupStream and SetupMetrics) from nginx configuration instead of when first request is being processed. In this way:
It also allows us not to wait for first request to populate cache etc.