Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Security Engine support #755

Merged
merged 209 commits into from
Dec 15, 2023
Merged

Application Security Engine support #755

merged 209 commits into from
Dec 15, 2023

Conversation

blotus
Copy link
Member

@blotus blotus commented Jun 2, 2023

Add support for new items:

  • appsec-rules
  • appsec-configs

Add support for appsec tests.

@blotus blotus marked this pull request as draft June 2, 2023 09:55
@blotus blotus marked this pull request as ready for review June 12, 2023 16:31
@blotus blotus marked this pull request as draft June 12, 2023 16:32
Copy link

Hello @buixor,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @blotus,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @AlteredCoder,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @buixor and thank you for your contribution!

I'm a bot that helps maintainers to validate scenarios and ensure they include all the required information.
I've found some errors in your scenarios, please fix them and re-submit your PR, or ask for help if you need it.

The following items have errors:

crowdsecurity/vpatch-CVE-2023-38205:

Mitre ATT&CK

Information about mitre attack can be found here.
As an example, some common mitre attack techniques:

  • T1110 for bruteforce attacks
  • T1595 and T1190 for exploitation of public vulnerabilities
  • T1595 for generic scanning of exposed applications

Expected format is (where XXXX is the technique ID):

labels:
  classification:
    - attack.TXXXX

CVEs

If your scenario covers a specific CVE (Common Vulnerabilities and Exposures), please add it.

Expected format is (where CVE-XXX-XXX is the CVE ID):

labels:
  classification:
    - cve.CVE-XXX-XXX

Behaviors

Please identify the behavior(s) your scenario is targeting. You can find the list of available behaviors here.

Expected format is (where <behavior> is the behavior you want to target):

labels:
  behavior: <behavior>

See the labels documentation for more information.

Copy link

Hello @AlteredCoder,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @AlteredCoder,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @AlteredCoder,

Scenarios are compliant with the taxonomy, thank you for your contribution!

Copy link

Hello @AlteredCoder and thank you for your contribution!

It seems that the following scenarios are not part of the 'crowdsecurity/appsec-virtual-patching' collection:

crowdsecurity/vpatch-CVE-2023-38205
crowdsecurity/vpatch-CVE-2023-24489
crowdsecurity/vpatch-CVE-2021-3129
crowdsecurity/vpatch-CVE-2021-22941
crowdsecurity/vpatch-CVE-2019-12989
crowdsecurity/vpatch-CVE-2022-44877

Copy link

Hello @AlteredCoder,

Scenarios/AppSec Rule are compliant with the taxonomy, thank you for your contribution!

Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Hello @AlteredCoder,

The new VPATCH Rule is compliant, thank you for your contribution!

@blotus blotus merged commit ba95eb3 into master Dec 15, 2023
3 of 4 checks passed
@blotus blotus deleted the waf-rules branch December 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants