Introduce setting for controlling thread sort order #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,12 +135,14 @@ function cfth_thread_notice($posts, $query) { | |||
|
|
|||
| function cfth_timeline_posts($term_id) { | |||
| $term = get_term_by('id', $term_id, 'threads'); | |||
| $term_meta = get_term_meta( $term_id, 'threads_meta', true ); | |||
There was a problem hiding this comment.
This function was introduced as of 4.4.0. Using it here means that the plugin's required minimum WP version will be 4.4.0. That means an update to the README and the plugin's heading docblock.
We should also, for good measure, confirm this function exists using if ( function_exists( 'get_term_meta' ) ) simply because it is so new
|
Other general feedback: The new functions are missing PHP DocBlocks. Please add these in and follow the WP coding standards for documentation: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #2