Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role-{rolename}.php fix #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

role-{rolename}.php fix #12

wants to merge 3 commits into from

Conversation

cfree
Copy link
Contributor

@cfree cfree commented Apr 10, 2013

Problem: role-{rolename}.php was not working in any context

Solution: Changed parameter within cfct_username_to_id() to retrieve a user object via the proper username (login) instead of the ID using the get_user_by() function. Confirmed working in all contexts.

@cfree
Copy link
Contributor Author

cfree commented Apr 10, 2013

This doesn't appear to work when using default permalinks. Investigating further.

@cfree
Copy link
Contributor Author

cfree commented Apr 10, 2013

Slug parameter failed in cfct_username_to_id() when the site is using default permalinks. Updated cfct_choose_general_template_role() to use post object's author (ID) variable if one is set and avoiding use of cfct_username_to_id(), but falling back if no author is set.

Confirmed functionality of role-{rolename}.php with both default and fancy permalinks and both single- and multi-word usernames. Ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant