Playing with fast_jsonapi

[steveyken]

Ticket Link:

NOTE: Specify ticket link

What does this PR do?

FEATURE: Specify feature name

BUG: Specify bug

NOTE: Give a description of what this PR does. If it fixes any bug, specify cause of an issue and approach/solution added to fix that issue.

Impacted Areas

NOTE: List any impacted areas (e.g. Dashboard > My Active Offers > scheduled )

Screenshots

NOTE: Attach screeenshots if PR contains any UI changes

Mockup Link

Note: Specify mockup link

Linked PR's:

NOTE: If these changes are related to some existing PR or fixes any issue from existing PR changes, specify PR links.

Linked Slack conversation:

NOTE: IF there is any conversation happened for current changes in any of the slack channel, mention the slack message link.

Any Open question(s) or challenge(s):

[patrixr]

@steveyken May I suggest moving files to app/serializers/api/v2/serializers/image.rb

[steveyken]

Good suggestion! And feel free to hack on this branch in an adhoc fashion... The more I think about the current issues we have, the more I realize it's less about which gems we're using (AMS/PES vs fast_jsonapi) and more about good serializer design principles. We need more shallowness and separation of concerns (models)

…

On Wed, Nov 27, 2019, 12:50 Patrick R ***@***.***> wrote: @steveyken <https://github.com/steveyken> May I suggest moving files to app/serializers/api/v2/serializers/image.rb — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#860?email_source=notifications&email_token=AABENTUW3BIEHTDTQJO7TBDQVX4BTA5CNFSM4JSA3ZP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFII3JY#issuecomment-558927271>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABENTRWW2LCR2YORILQWULQVX4BTANCNFSM4JSA3ZPQ> .

[patrixr]

@steveyken agreed, I think V2 is an opportunity for a fresh start :)

[patrixr]

Test @steveyken Hello