update ci tools to publish arm64 docker images #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garasubo
force-pushed
the
more-arm64-docker-builds-2
branch
from
9c899c5 to
99fb11f
Compare
|
looks good so far, I did some restructuring in #1635 feel free to incorporate those (or not :) ) |
garasubo
commented
Mar 26, 2025
| @@ -123,10 +123,27 @@ jobs: | |||
| env: | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
| generate-matrix-for-build: | |||
There was a problem hiding this comment.
In build job, we need to run docker build and test for each (target, platform) pair. In push job, we need to run build for each target with multiple targets.
|
@Emilgardis Thanks. I looked into your PR, but it looked hard to merge it to mine. |
|
@Emilgardis Any update on this? |
|
Yes, it looks good! but I've not taken the time to test it myself yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CI and related tools to publish multi-arch images
Ref: #1597, #1630