Skip to content

perf(delete): avoid loading every linked book when deleting/editing a book #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manut999 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

perf(delete): avoid loading every linked book when deleting/editing a book #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cps/editbooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,16 @@ def remove_objects(db_book_object, db_session, del_elements):
for del_element in del_elements:
db_book_object.remove(del_element)
changed = True
if len(del_element.books) == 0:
# Ask the database whether any book still links to this element instead of
# loading del_element.books: for a common language or tag that pulls every
# linked book (plus all its selectin relationships) into memory, which took
# ~40 s per deleted book on a 190k-book library.
db_session.flush()
still_used = (db_session.query(db.Books.id)
.with_parent(del_element, type(del_element).books)
.limit(1)
.first())
if still_used is None:
db_session.delete(del_element)
db_session.flush()
return changed
Expand Down