Migrate to maplibre #354
Migrate to maplibre #354
Conversation
and remove now unnecessary version handling
otto doesn't like to be registered twice
- disable observerinfowindow for now - disable custom gpx track feature for now
Is also used by maplibre. Needed to comply with usage policy.
We already gave a declararion in play console
Restructure and use version catalog as in current best practice examples
|
This looks great. Is there anything from a code perspective that needs specific attention? To be fair: my knowledge of Android is limited and especially Java 😄 But Maplibre seems like a good choice. I was also thinking about adopting it at some point and would be very interested in your experience with it after a while as you pointed out |
|
Looks great! Thanks for the initiative! ❤️ |
|
I'd be happy to install and test an apk of this if that would be helpful. Thank you for your work! |
That would be great - thank you! I attached the zipped apk here. You might have to uninstall the official version first before install. |
|
The map looks great and it allows zooming with one finger, a feature that I have missed for a long time 👍 The menu doesn't work at all for me, unfortunately. It slides in from the left and slides back out as soon as I tap anywhere on the screen, but neither the "oberserver mode" toggle nor any of the other menu entries can be selected. Pixel 3a with current LineageOS and MicroG. Does this work on other devices? (Mine is a bit of an outlier admittedly, but I've never had such a UI issue before.) |
|
@dreua Thank you for the feedback. That's interesting. Neither on an actual device nor on any of the emulators do I see that issue. Lineage should not be a problem. MicroG neither, since we do not use any play services. I will do some digging... |
|
That is really strange, now I can't reproduce it. Maybe it was some ghost touching from my slightly cracked screen which interfered, no idea but that is my best guess for now. Sorry for sending you on a goose chase here. Something minor I notice now is that the map is blank (white) every time after I switch back to it from a different view inside the app (chat, rules, settings...) and takes a small moment to load. It doesn't happen when I switch to an entirely different app (e.g. Signal, Browser, Launcher...) in this case the map is right back like nothing happened. It is usable, maybe less of an issue on more powerful (modern) devices but it is noticable on my device and maybe an easy fix. (It does not matter if I switch back with a back gesture or using the menu to go to the map.) |
|
Thanks for the update!
Regarding the map: the map is recreated every time you switch back to the
map view. In the past this was not much of a delay, since osndroid was more
lightweight. Now on slower devices it makes sense, that it's noticeable. In
the course of the kotlin migration this will probably change anyway, so we
won't change that now.
Thanks again for testing.
From my point of view, this should be good to go for a first release then.
I will do that in the coming days.
…On Sun, 23 Nov 2025, 15:56 David Auer, ***@***.***> wrote:
*dreua* left a comment (criticalmaps/criticalmaps-android#354)
<#354 (comment)>
That is really strange, now I can't reproduce it. Maybe it was some ghost
touching from my slightly cracked screen which interfered, no idea but that
is my best guess for now. Sorry for sending you on a goose chase here.
Something minor I notice now is that the map is blank (white) every time
after I switch back to it from a different view inside the app (chat,
rules, settings...) and takes a small moment to load. It doesn't happen
when I switch to an entirely different app (e.g. Signal, Browser,
Launcher...) in this case the map is right back like nothing happened. It
is usable, maybe less of an issue on more powerful (modern) devices but it
is noticable on my device and maybe an easy fix.
—
Reply to this email directly, view it on GitHub
<#354 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGWNG7373A3X5TFCDLEJNT36HDKNAVCNFSM6AAAAACLSOAJKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNRYGAZTQOJTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
That sounds very good to me, considering that I don't switch views in the app too often usually. And as I said, it is still very usable, happy to trade this short moment for the one finger zoom feature 👍 |
|
Closes: #278 |
See #358 |
5 participants
Note: This is a draft and not ready to be merged yet!
Hey everyone,
I found some time to migrate the map sdk from the now defunct osmdroid to maplibre native.
At the same time I bumped the minSdk version to 26 to get rid of a lot of workarounds for older android version barely used anymore and to enable using more modern features.
This PR includes:
This includes a switch of the tileserver from the raster based osm server to the new vector based one: https://vector.openstreetmap.org/. The usage policy stays the same (basically proper attribution, contact information in user agent and no intense/commercial use) and I assume we will still be fine in that regard.
That being said there is still some stuff to do:
Once that has been done I would release this as Version 3.0.0 while at the same time bumping the VersionCode to 100. This will allow us to still keep the current version with minsdk 16 for as long as it works and also enable us to update it if needed. This works since play store will always serve users the version with the highest versioncode that will run on their specific device.
My suggestion would be to get this done and then afterwards start the migration to kotlin and compose to get the code base up to speed.
@mltbnz @stephanlindauer : I would like to hear you thoughts on this and would also appreciate it if you could check out this branch and test it.