Skip to content

Fix NPE on configuration change #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbalster merged 1 commit into from
Sep 29, 2025
Merged

Fix NPE on configuration change #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/de/stephanlindauer/criticalmaps/managers/LocationUpdateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class LocationUpdateManager {
private final PermissionCheckHandler permissionCheckHandler;
private final App app;
private boolean isUpdating = false;
private boolean isEventBusRegistered = false;

private static final float LOCATION_REFRESH_DISTANCE = 20; //20 meters
private static final long LOCATION_REFRESH_TIME = 12 * 1000; //12 seconds
Expand Down Expand Up @@ -160,7 +161,11 @@ public void initialize() {
} else {
setStatusEvent();
}
eventBus.register(this);

if(!isEventBusRegistered) {
eventBus.register(this);
isEventBusRegistered = true;
}

// Short-circuit here: if no provider exists don't start listening
if (noProviderExists) {
Expand Down Expand Up @@ -232,6 +237,7 @@ public void handleShutdown() {
} catch (IllegalArgumentException ignored) {
// nothing we can do
}
isEventBusRegistered = false;
}

private void publishNewLocation(Location location) {
Expand Down
Loading