-
Notifications
You must be signed in to change notification settings - Fork 71
merge: Sync changes from qa to main #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d37a87e
f5ce197
fca8aba
0ca57b2
8557feb
e5b3611
2e4e6fd
1cc84f0
9aa5c8f
cb2a713
97a2b7e
38005c5
97af95a
855603d
255236a
2593951
9deb93a
b45186f
4481091
732ac88
1fb387f
ff3c273
4816fb6
c023f07
addfec5
804c0b9
1a183c0
541f603
ecfac3d
ff8aef3
b136932
c4d66f2
1b4b699
ddbfb57
97d8f79
b19ec58
48ab913
9751adc
c6b330b
084a268
d0a6267
d616a85
504e4c3
fe5fbad
79fa61f
b301496
a2e2f4b
efd4276
679cfcd
3e00a4e
759dd3b
fa7886f
89caf05
92238cd
4189aa1
ab9fb63
820863a
0012787
d4c1523
79ada17
bdb89f2
b19590c
5e650c2
c4b4c7b
f08f732
f93c933
847e366
90cf16a
2ca4baa
a6b69fd
7600413
19975c9
bd4cc44
7f4071b
bf52105
c609bf1
055d9bb
9a38856
3119cc7
2a446e6
dc24f10
803d7eb
a91f3e6
230dc9a
18d1086
4703492
d748d20
2571b42
c43f3c2
00498a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| allowRemediationCommits: | ||
| individual: true | ||
| thirdParty: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,12 @@ jobs: | |
| id: get_tag | ||
| run: echo "TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
|
Comment on lines
+47
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainPin Docker actions to commit SHAs Pin setup-qemu and setup-buildx to full-length SHAs instead of floating major tags. I can fetch and pin the current SHAs and open a follow-up patch; confirm if you want this done now. 🏁 Script executed: #!/bin/bash
echo "setup-qemu-action v3 SHA:"
curl -s https://api.github.com/repos/docker/setup-qemu-action/git/refs/tags/v3 \
| grep -m1 '"sha"' \
| sed -E 's/.*"sha": "([^"]+)".*/\1/'
echo "setup-buildx-action v3 SHA:"
curl -s https://api.github.com/repos/docker/setup-buildx-action/git/refs/tags/v3 \
| grep -m1 '"sha"' \
| sed -E 's/.*"sha": "([^"]+)".*/\1/'Length of output: 485 Pin Docker actions to exact SHAs .github/workflows/continuous-delivery.yml
🤖 Prompt for AI Agents |
||
| - name: Log in to GitHub Container Registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
|
|
@@ -57,6 +63,7 @@ jobs: | |
| context: . | ||
| file: Dockerfiles/Dockerfile.${{ matrix.service }} | ||
| push: true | ||
| platforms: linux/amd64,linux/arm64 | ||
| tags: | | ||
| ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ matrix.service }}:${{ env.TAG }} | ||
| ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ matrix.service }}:latest | ||
| ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ matrix.service }}:latest | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,9 +59,9 @@ jobs: | |
| # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF | ||
| # format to the repository Actions tab. | ||
| - name: "Upload artifact" | ||
| uses: actions/upload-artifact@97a0fba1372883ab732affbe8f94b823f91727db # v3.pre.node20 | ||
| uses: actions/upload-artifact@v4 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainPin upload-artifact to a commit SHA for Supply-Chain hardening Use a full-length commit SHA instead of a floating tag to satisfy Scorecard’s Pinned-Dependencies check. Would you like me to generate a PR-ready patch with the latest v4 commit SHA pinned? I can also add step-security/harden-runner for network egress locking. 🏁 Script executed: #!/bin/bash
# Verify usage of floating tag for upload-artifact action
rg -nP "actions/upload-artifact@v4" -C3 .github/workflows/scorecard.yml || echo "No match found"Length of output: 394 Pin upload-artifact action to a full commit SHA uses: actions/upload-artifact@v4with a specific commit SHA (e.g. 🤖 Prompt for AI Agents |
||
| with: | ||
| name: SARIF file | ||
| name: sarif-file | ||
| path: results.sarif | ||
| retention-days: 5 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,13 @@ PROTOCOL=${12} | |
| TENANT=${13} | ||
| AFJ_VERSION=${14} | ||
| INDY_LEDGER=${15} | ||
| INBOUND_ENDPOINT=${16} | ||
| SCHEMA_FILE_SERVER_URL=${17} | ||
| AGENT_API_KEY=${18} | ||
| ADMIN_PORT_FILE="$PWD/agent-provisioning/AFJ/port-file/last-admin-port.txt" | ||
| INBOUND_PORT_FILE="$PWD/agent-provisioning/AFJ/port-file/last-inbound-port.txt" | ||
| ADMIN_PORT=8001 | ||
| INBOUND_PORT=9001 | ||
|
|
||
|
Comment on lines
+20
to
27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainAGENT_API_KEY added: ensure it’s used consistently You accept AGENT_API_KEY but do not mask it in logs and do not validate presence. Run-time check: 🏁 Script executed: #!/bin/sh
if [ -z "$AGENT_API_KEY" ]; then echo "AGENT_API_KEY is empty"; exit 1; fiLength of output: 79 Validate and mask AGENT_API_KEY
🧰 Tools🪛 Shellcheck (0.10.0)[warning] 20-20: INBOUND_ENDPOINT appears unused. Verify use (or export if used externally). (SC2034) 🤖 Prompt for AI Agents |
||
| echo "AGENCY: $AGENCY" | ||
| echo "EXTERNAL_IP: $EXTERNAL_IP" | ||
|
|
@@ -34,11 +41,6 @@ echo "TENANT: $TENANT" | |
| echo "AFJ_VERSION: $AFJ_VERSION" | ||
| echo "INDY_LEDGER: $INDY_LEDGER" | ||
|
|
||
| ADMIN_PORT_FILE="$PWD/agent-provisioning/AFJ/port-file/last-admin-port.txt" | ||
| INBOUND_PORT_FILE="$PWD/agent-provisioning/AFJ/port-file/last-inbound-port.txt" | ||
| ADMIN_PORT=8001 | ||
| INBOUND_PORT=9001 | ||
|
|
||
| increment_port() { | ||
| local port="$1" | ||
| local lower_limit="$2" | ||
|
|
@@ -144,7 +146,9 @@ cat <<EOF >${CONFIG_FILE} | |
| ], | ||
| "webhookUrl": "$WEBHOOK_HOST/wh/$AGENCY", | ||
| "adminPort": $ADMIN_PORT, | ||
| "tenancy": $TENANT | ||
| "tenancy": $TENANT, | ||
| "schemaFileServerURL": "$SCHEMA_FILE_SERVER_URL", | ||
| "apiKey": "$AGENT_API_KEY" | ||
| } | ||
| EOF | ||
|
|
||
|
|
@@ -225,7 +229,7 @@ if [ $? -eq 0 ]; then | |
| container_logs=$(docker logs $(docker ps -q --filter "name=${AGENCY}_${CONTAINER_NAME}")) | ||
|
|
||
| # Extract the token from the logs using sed | ||
| token=$(echo "$container_logs" | sed -nE 's/.*API Token: ([^ ]+).*/\1/p') | ||
| token=$(echo "$container_logs" | sed -nE 's/.*** API Key: ([^ ]+).*/\1/p') | ||
|
|
||
| # Print the extracted token | ||
| echo "Token: $token" | ||
|
Comment on lines
231
to
235
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix fragile token extraction The sed regex with unescaped asterisks is unreliable. Extract by key name. -token=$(echo "$container_logs" | sed -nE 's/.*** API Key: ([^ ]+).*/\1/p')
+token=$(printf "%s" "$container_logs" | awk -F'API Key: ' '/API Key:/ {print $2}' | awk '{print $1; exit}')Also avoid echoing the token.
🤖 Prompt for AI Agents |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm DCO app supports these keys and that org repo has the app installed
The keys
allowRemediationCommits.individualand.thirdPartylook plausible but DCO config schemas vary by app. Please verify the GitHub App you use for DCO enforcement recognizes these options, otherwise the config will be ignored.To validate quickly:
You can also confirm the exact config keys with a quick web check:
🏁 Script executed:
Length of output: 528
🌐 Web query:
💡 Result:
Yes. The probot DCO app supports a .github/dco.yml schema that includes an allowRemediationCommits block with boolean flags individual and thirdParty. Example forms:
Enable individual remediation:
allowRemediationCommits:
individual: true
Enable third‑party remediation (requires individual: true):
allowRemediationCommits:
individual: true
thirdParty: true
(Other options such as require: members: false are also supported.) [1][2]
Install or enable the GitHub DCO App
The keys
allowRemediationCommits.individualandthirdPartyare valid for the probot DCO schema, but the GH CLI call (gh api repos/credebl/platform/installations) returned 404, indicating the DCO app isn’t installed or authorized on this repo. Please install or enable the DCO GitHub App to enforce these settings.🤖 Prompt for AI Agents