feat(content): add video teaser across all layers#65
Open
stacelKonrad wants to merge 5 commits intomainfrom
Open
feat(content): add video teaser across all layers#65stacelKonrad wants to merge 5 commits intomainfrom
stacelKonrad wants to merge 5 commits intomainfrom
Conversation
Add teaserVideo content type with lazy-loading, skeleton and error state. Wires the full stack: Contentful migration, GraphQL fragment, Zod schema, mapper, contract, presentation block, and Storybook story.
Replace hardcoded "Video unavailable" string with next-intl translation key.
mstarzak
reviewed
Mar 26, 2026
Comment on lines
+252
to
+264
| 'en-US': { | ||
| title: 'New in', | ||
| caption: 'Discover the latest trends.', | ||
| link: linkRef, | ||
| }, | ||
| 'de-DE': { | ||
| title: 'Neu eingetroffen', | ||
| caption: 'Entdecke die neuesten Trends.', | ||
| link: linkRef, | ||
| }, | ||
| 'autoplay': true, | ||
| 'controls': false, | ||
| }) |
Collaborator
There was a problem hiding this comment.
Mixed locale keys and non-locale fields, maybe worth to standarize this and pass locale fields some structured way?
Collaborator
There was a problem hiding this comment.
Not sure about some settings in one locale and missing in the second though.
integrations/contentful-migration/migrations/01-02-teasers/01-02-16-video.ts
Show resolved
Hide resolved
apps/presentation/features/content/teasers/teaser-video-block.tsx
Outdated
Show resolved
Hide resolved
apps/presentation/features/content/teasers/teaser-video-block.tsx
Outdated
Show resolved
Hide resolved
Move autoplay/controls into en-US locale object in VIDEO_TEASER data. Replace block-level CmsLink with an absolute overlay to preserve video controls interaction. Add playsInline for autoplay on mobile. Rename migration file to 01-02-16-video and remove redundant brand component migration that was merged into the sequence.
mstarzak
reviewed
Mar 27, 2026
Comment on lines
+252
to
+264
| 'en-US': { | ||
| title: 'New in', | ||
| caption: 'Discover the latest trends.', | ||
| link: linkRef, | ||
| }, | ||
| 'de-DE': { | ||
| title: 'Neu eingetroffen', | ||
| caption: 'Entdecke die neuesten Trends.', | ||
| link: linkRef, | ||
| }, | ||
| 'autoplay': true, | ||
| 'controls': false, | ||
| }) |
Collaborator
There was a problem hiding this comment.
Not sure about some settings in one locale and missing in the second though.
| {link && ( | ||
| <CmsLink | ||
| link={link} | ||
| className='absolute inset-0 z-10' |
Collaborator
There was a problem hiding this comment.
I think now we could have problems for combination of link and controls as it wouldn't be possible to use controls at all due to overlay.
| link={link} | ||
| className='absolute inset-0 z-10' | ||
| aria-label={link.title} | ||
| /> |
Collaborator
There was a problem hiding this comment.
CmsLink falls back to its label if there is no children passed.
| <CmsLink | ||
| link={link} | ||
| className='absolute inset-0 z-10' | ||
| aria-label={link.title} |
Collaborator
There was a problem hiding this comment.
aria-label will be ignored by CmsLink, most likely we need to pass rest props in CmsLink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add teaserVideo content type with lazy-loading, skeleton and error state. Wires the full stack: Contentful migration, GraphQL fragment, Zod schema, mapper, contract, presentation block, and Storybook story.