-
-
Notifications
You must be signed in to change notification settings - Fork 63
Add Museums Victoria fetch #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@oree-xx I have opened a new pull request. I guess that is much better |
|
@sbarhin ohh okay great. |
|
@TimidRobot There are several file changes in my PR, this is due to pulling from the main branch where I believe you merged a certain PR. These changes have taken effect in my branch hence those file changes in my PR. |
Please revisit the documentation on keeping a branch/fork synchronized with upstream and on resolving merge conflicts. This PR won't be reviewed or merged while these issue are present. |
I will do that please. Thank you |
|
@TimidRobot I believe we are good now |
|
Please synchronize your fork/branch and add your data source to |
|
The script takes too long to run (I canceled after 10 minutes). Please add a |
@TimidRobot Please should the --limit apply individual record types or the total number of records altogether? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@sbarhin Which implementation will satisfies the stated goal? |
@sbarhin force pushes are generally a worst practice and should be avoided when unnecessary. |
I think per individual record type will do |
Fixes
Description
This PR implements automation for Museum Victoria data fetching as discussed in issue #215. The implementation follows the established patterns from existing fetch scripts.
This purpose of this file is to fetch all the records from the Museum Victoria API, then saving the necessary response fields needed for the next phase (processing phase).
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin