taskgroup: drop *Group from the signature of start functions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danderson
approved these changes
Oct 5, 2024
While it is mildly convenient in a few cases to chain construction of the group with starting a goroutine, it has turned out not to be worthwhile in practice. Apart from the tests (which are hereby updated not to do that anymore), a search of GitHub suggests nobody uses this -- even in code I wrote.
creachadair
force-pushed
the
mjf/unchain
branch
from
17c0521 to
e8a604a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is mildly convenient in a few cases to chain construction of the group
with starting a goroutine, it has turned out not to be worthwhile in practice.
Apart from the tests (which are hereby updated not to do that anymore), a
search of GitHub suggests nobody uses this -- even in code I wrote.