-
Notifications
You must be signed in to change notification settings - Fork 0
Instructions: Balance responsibilities. Advise language. #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the AI prompt instructions to merge and expand the impersonation section into a two-task directive: (1) translate data questions into CrateDB SQL queries with expected result format, and (2) extract precise answers from CrateDB documentation; added concise, active‑voice style guidance. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3d7721b to
01cf7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/cratedb_about/prompt/instructions.md (1)
11-13: Reduce repetitive "You" sentence beginnings.Three successive sentences begin with "You", which creates stylistic monotony. Restructure one or more of these sentences to vary the sentence patterns and improve readability.
Apply this diff to address the repetition:
- You are a friendly assistant who processes information from CrateDB and its documentation. - You are a CrateDB database engineer, focused on technical level and optimization abilities. - You have two tasks: a) Translate questions about data into accurate CrateDB SQL queries and present the expected result format. b) Discover optimal information from the CrateDB knowledgebase, inquire the technical documentation, and come up with precise answers. + You are a friendly assistant and CrateDB database engineer who processes information from CrateDB, focused on technical level, optimization abilities, and data insights. + Your two tasks are: a) Translate questions about data into accurate CrateDB SQL queries and present the expected result format. b) Extract precise answers from the CrateDB knowledgebase and technical documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/cratedb_about/prompt/instructions.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: amotl
Repo: crate/about PR: 32
File: src/cratedb_about/outline/cratedb-outline.yaml:321-329
Timestamp: 2025-05-15T21:25:54.870Z
Learning: In the CrateDB outline YAML, content organization prioritizes thematic grouping (keeping related topics together) over content type grouping (separating tutorials from reference docs), as demonstrated by placing the multi-tenancy tutorial alongside user management and privileges documentation in the API section.
📚 Learning: 2025-05-15T21:25:54.870Z
Learnt from: amotl
Repo: crate/about PR: 32
File: src/cratedb_about/outline/cratedb-outline.yaml:321-329
Timestamp: 2025-05-15T21:25:54.870Z
Learning: In the CrateDB outline YAML, content organization prioritizes thematic grouping (keeping related topics together) over content type grouping (separating tutorials from reference docs), as demonstrated by placing the multi-tenancy tutorial alongside user management and privileges documentation in the API section.
Applied to files:
src/cratedb_about/prompt/instructions.md
🪛 LanguageTool
src/cratedb_about/prompt/instructions.md
[style] ~13-~13: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cal level and optimization abilities. - You have two tasks: a) Translate questions ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🔇 Additional comments (1)
src/cratedb_about/prompt/instructions.md (1)
15-15: Well-motivated addition of writing style guidance.The new directive emphasizing concise language, active voice, and avoiding verbosity aligns well with the expanded task responsibilities and sets clear expectations for response quality. This complements the technical guidelines below nicely.
surister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
This and that about LLM response tuning:
Summary by CodeRabbit