Add Bryston protocol #2203
Open
Add Bryston protocol #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiKiZe
reviewed
May 10, 2025
There was a problem hiding this comment.
Thanks for the PR!
There is some linter issues that needs to be resolved, and build failures due to the Serial.print
This is just a quick look, there might be more things that needs resolving as well.
It would be good to have unit tests, a few captures of any of the original remotes would be needed as test data, with that we can help with test cases if you want to.
| /// @param[in] nbits The number of bits of message to be sent. | ||
| /// @param[in] repeat The number of times the command is to be repeated. | ||
| void IRsend::sendBryston(uint64_t data, uint16_t nbits, uint16_t repeat) { | ||
| Serial.printf("Sending Bryston: %016llX\n", data); |
There was a problem hiding this comment.
Probably a leftover from debug during development that was forgotten to be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Bryston protocol.
Tested on BP19 and BR20 but should work across all Bryston products.