Skip to content

Adding support for reproducible builds. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding support for reproducible builds. #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f057e
Adding support for reproducible builds.
Feb 10, 2022
46e79ca
Adding support for reproducible builds. | minor formatting issue.
Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,18 @@
<version>4.13.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.github.stefanbirkner</groupId>
<artifactId>system-rules</artifactId>
<version>1.19.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.github.stefanbirkner</groupId>
<artifactId>system-lambda</artifactId>
<version>1.1.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down
12 changes: 11 additions & 1 deletion src/main/java/org/redline_rpm/Builder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,17 @@ public class Builder {
*/
public Builder() {
format.getHeader().createEntry( HEADERI18NTABLE, "C");
format.getHeader().createEntry( BUILDTIME, ( int) ( System.currentTimeMillis() / 1000));
long sourceDateEpoch=0;
long buildTime = System.currentTimeMillis()/1000;
try {
sourceDateEpoch = Long.parseLong(System.getenv("SOURCE_DATE_EPOCH"));
}catch(NumberFormatException e) {
// do nothing
}
if(sourceDateEpoch!=0){
buildTime = sourceDateEpoch;
}
format.getHeader().createEntry( BUILDTIME, ( int)buildTime);
format.getHeader().createEntry( RPMVERSION, "4.4.2");
format.getHeader().createEntry( PAYLOADFORMAT, "cpio");
format.getHeader().createEntry( PAYLOADCOMPRESSOR, "gzip");
Expand Down
27 changes: 26 additions & 1 deletion src/test/java/org/redline_rpm/BuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package org.redline_rpm;

import org.junit.Rule;
import org.junit.Test;
import org.redline_rpm.Scanner;
import org.junit.contrib.java.lang.system.EnvironmentVariables;
import org.redline_rpm.header.Format;
import org.redline_rpm.header.Header.HeaderTag;
import org.redline_rpm.header.Header;
Expand All @@ -23,6 +24,9 @@

public class BuilderTest extends TestBase {

@Rule
public final EnvironmentVariables environmentVariables = new EnvironmentVariables();

@Test
public void testLongNameTruncation() throws Exception {
Builder builder = new Builder();
Expand Down Expand Up @@ -205,6 +209,27 @@ public void testProvideOverride() throws Exception {

}

/**
* Allows the Build Date of the RPM to be overridden by the environment variable SOURCE_DATE_EPOCH
* See https://reproducible-builds.org/docs/source-date-epoch/
* @throws Exception
*/
@Test
public void testReproducibleBuilds() throws Exception {
final String EXPECTED_BUILD_TIME="1644516016";
environmentVariables.set("SOURCE_DATE_EPOCH", EXPECTED_BUILD_TIME);

Builder builder = new Builder();
builder.setPackage("testReproducibleBuilds", "1.0", "1");
builder.build( new File( getTargetDir()));

Format format = new Scanner().run(channelWrapper("target" + File.separator + "testReproducibleBuilds-1.0-1.noarch.rpm"));
System.out.println(EXPECTED_BUILD_TIME+" hhhhhh ==" + format.getHeader().getEntry(HeaderTag.BUILDTIME).toString());

assertEquals("buildtime[tag=1006,type=4,count=1,size=4,offset=36]\n\t"+EXPECTED_BUILD_TIME+", ", format.getHeader().getEntry(HeaderTag.BUILDTIME).toString());

}

@Test
public void testAddHeaderEntry() {
Builder builder = new Builder();
Expand Down