Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sorting more keywords and nested types #10

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

craigktreasure
Copy link
Owner

  • Added support for sorting members with the readonly keyword and nested types.
  • Added more details to the exception that is thrown while trying to sort by name to make it easier to debug in the future.
  • Fixed a bug in the logic used to maintain whitespace when reordering that was causing comments to get swapped.

Fixed an issue with swapping comments while trying to maintain whitespace.

Fixes #9
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #10 (02104e4) into main (ce4f97d) will increase coverage by 2.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #10      +/-   ##
===========================================
+ Coverage   97.95%   100.00%   +2.04%     
===========================================
  Files           2         3       +1     
  Lines          98       113      +15     
===========================================
+ Hits           96       113      +17     
+ Misses          2         0       -2     
Files Coverage Δ
...emberOrder.CodeFixes/MemberOrderCodeFixProvider.cs 100.00% <100.00%> (ø)
...berOrder/MemberOrder.CodeFixes/SyntaxExtensions.cs 100.00% <100.00%> (ø)
src/MemberOrder/MemberOrder/MemberOrderAnalyzer.cs 100.00% <100.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craigktreasure craigktreasure merged commit 4aa9597 into main Oct 3, 2023
@craigktreasure craigktreasure deleted the craig/bug-fixes branch October 3, 2023 07:48
@craigktreasure
Copy link
Owner Author

Fixed #8 and #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant