changelog, ecs, phpstan

CHANGELOG.md

@@ -9,9 +9,13 @@
 - It’s now possible to manually sync Stripe customer data on Edit User pages. ([#21](https://github.com/craftcms/stripe/pull/21))
 - Added support for selecting products in Link fields. ([#26](https://github.com/craftcms/stripe/pull/26))
 - It’s now possible to save custom field data against a new Subscription when using a checkout form. ([#25](https://github.com/craftcms/stripe/issues/25))
+- Admin privileges (but not admin changes) are now required when creating, editing, updating and deleting webhook. ([#30](https://github.com/craftcms/stripe/pull/30))
+- Webhook settings are now stored in a separate table and not in the plugin’s settings. ([#30](https://github.com/craftcms/stripe/pull/30))
 - Added `craft\stripe\events\StripeEvent`. ([#17](https://github.com/craftcms/stripe/issues/17))
 - Added `craft\stripe\services\Webhooks::EVENT_STRIPE_EVENT`. ([#17](https://github.com/craftcms/stripe/issues/17))
 - Added `craft\stripe\linktypes\Product`. ([#26](https://github.com/craftcms/stripe/pull/26))
+- Deprecated `craft\stripe\models\Settings->$webhookSigningSecret` ([#30](https://github.com/craftcms/stripe/pull/30))
+- Deprecated `craft\stripe\models\Settings->$webhookId` ([#30](https://github.com/craftcms/stripe/pull/30))
 - Fixed a SQL error that occurred when syncing a subscriptions that were missing a `latest_invoice` value. ([#21](https://github.com/craftcms/stripe/pull/21))
 - Fixed links to stripe dashboard when in live mode. ([#21](https://github.com/craftcms/stripe/pull/21))
 - Stripe now requires Craft CMS 5.3.0 or later. ([#26](https://github.com/craftcms/stripe/pull/26))

src/controllers/WebhooksController.php

@@ -10,8 +10,8 @@
 use Craft;
 use craft\helpers\App;
 use craft\helpers\UrlHelper;
-use craft\stripe\records\Webhook as WebhookRecord;
 use craft\stripe\Plugin;
+use craft\stripe\records\Webhook as WebhookRecord;
 use craft\web\Controller;
 use Stripe\Exception\SignatureVerificationException;
 use Stripe\Exception\UnexpectedValueException;

src/records/Webhook.php

@@ -8,9 +8,7 @@
 namespace craft\stripe\records;
 
 use craft\db\ActiveRecord;
-use craft\records\Element;
 use craft\stripe\db\Table;
-use yii\db\ActiveQueryInterface;
 
 /**
  * Webhook record

src/services/Webhooks.php

@@ -155,7 +155,7 @@ public function processEvent($event): void
      */
     public function getWebhookRecord(): Webhook
     {
-        /** @var Webhook $record */
+        /** @var Webhook|null $record */
         $record = Webhook::find()->one();
         return  $record ?? new Webhook();
     }