Fixed deprecation warnings being logged for TaxRate::$isVat

craftcms · Jan 31, 2025 · 2521e23 · 2521e23
1 parent daf41fd
commit 2521e23
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where the deprecated `TaxRate::$isVat` property was still being set. ([#3874](https://github.com/craftcms/commerce/issues/3874))
+
 ## 4.8.0 - 2025-01-30
 
 ### Store Management

diff --git a/src/models/TaxRate.php b/src/models/TaxRate.php
@@ -225,13 +225,13 @@ public function getIsEverywhere(): bool
      */
     public function getIsVat(): bool
     {
-        Craft::$app->getDeprecator()->log(__METHOD__, 'TaxRate::setIsVat() is deprecated.');
-
+        // Don't throw deprecation log as `isVat` is still set as an attribute so will be called when the model is serialized.
         return $this->hasTaxIdValidators();
     }
 
     /**
      * @param bool $isVat
+     * @throws DeprecationException
      * @deprecated in 4.8.0.
      */
     public function setIsVat(bool $isVat): void

diff --git a/src/services/TaxRates.php b/src/services/TaxRates.php
@@ -226,7 +226,6 @@ private function _createTaxRatesQuery(): Query
                 'dateUpdated',
                 'id',
                 'include',
-                'isVat',
                 'name',
                 'rate',
                 'removeIncluded',